Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump min compatibility to PHP 7.1.3 and PS 1.7.7, module version to 6.0.0 #562

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Bump min compatibility to PHP 7.1.3 and PS 1.7.7, module version to 6.0.0 #562

merged 3 commits into from
Nov 15, 2023

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Jun 7, 2023 •
edited
Loading

Questions Answers
Description? Please check the related issue.
Type? improvement
BC breaks? Does it break backward compatibility? yes
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes PrestaShop/PrestaShop#32841
How to test? CI green. Module works as usual on PS 1.7.7 and newer versions.

@leemyongpakvn leemyongpakvn changed the title Bump min compatibiliy to PHP 7.1.3 and PS 1.7.7, module version to 6.0.0 Bump min compatibility to PHP 7.1.3 and PS 1.7.7, module version to 6.0.0 Jun 7, 2023
@leemyongpakvn leemyongpakvn reopened this Jun 7, 2023
@kpodemski kpodemski added this to the 6.0.0 milestone Jun 8, 2023
@kpodemski
Copy link
Contributor

@leemyongpakvn it's all good, but I think we will wait for the release of 5.1.3 to let people use improvements you've made earlier on previous PrestaShop versions as well, sounds good?

@leemyongpakvn
Copy link
Contributor Author

@kpodemski OK. I'm not in rush.

@leemyongpakvn leemyongpakvn marked this pull request as draft June 8, 2023 07:19
@matks
Copy link
Contributor

matks commented Oct 2, 2023

@leemyongpakvn finally it's time 😄

@leemyongpakvn leemyongpakvn marked this pull request as ready for review October 2, 2023 08:17
@leemyongpakvn leemyongpakvn force-pushed the BumpMinCompatToPHP712nPS177_moduleVersionTo600 branch 2 times, most recently from c0f6e18 to 1353ec2 Compare October 2, 2023 09:01
@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Oct 3, 2023
@AureRita AureRita removed the waiting for QA Status: Waiting for QA feedback label Oct 5, 2023
@leemyongpakvn leemyongpakvn force-pushed the BumpMinCompatToPHP712nPS177_moduleVersionTo600 branch from a727ea6 to f90daf2 Compare November 13, 2023 13:37
@leemyongpakvn
Copy link
Contributor Author

@matks Rebased

@Hlavtox Hlavtox added the waiting for QA Status: Waiting for QA feedback label Nov 13, 2023
@florine2623 florine2623 self-assigned this Nov 14, 2023
florine2623
florine2623 reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @leemyongpakvn ,

Tested your PR on PS 1.7.7.8 PHP 7.1.33.

The module is not updated to 6.0.0.
It stays at v5.1.4.
Screenshot 2023-11-14 at 16 04 01

Could you check ?

On future versions (8.0.5, 8.1.2, develop), it is OK.

Screen.Recording.2023-11-14.at.16.05.19.mov

@florine2623 florine2623 added waiting for author Status: Waiting for Author Feedback and removed waiting for QA Status: Waiting for QA feedback labels Nov 14, 2023
@florine2623 florine2623 removed their assignment Nov 14, 2023
florine2623
florine2623 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT

The upgrade went well on 1.7.7.8.

Tested the following :
CRUD block reassurance
Check all tabs of modules
Check FO OK ✅

QA ✅

@florine2623 florine2623 self-assigned this Nov 14, 2023
@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed waiting for author Status: Waiting for Author Feedback labels Nov 14, 2023
@leemyongpakvn
Copy link
Contributor Author

Thanks all ;)

@leemyongpakvn leemyongpakvn merged commit 817a6a7 into PrestaShop:dev Nov 15, 2023
10 checks passed
@leemyongpakvn leemyongpakvn deleted the BumpMinCompatToPHP712nPS177_moduleVersionTo600 branch January 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisAUTHIE LouisAUTHIE LouisAUTHIE approved these changes

@florine2623 florine2623 florine2623 approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

@matks matks matks approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️ Status: QA-Approved
Projects
PR Dashboard
Archived in project
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Bump minimum compatibility to PHP 7.1.3 and PS 1.7.7 for Native Modules
8 participants
@leemyongpakvn @kpodemski @matks @Hlavtox @florine2623 @LouisAUTHIE @ps-jarvis @AureRita