-
Notifications
You must be signed in to change notification settings - Fork 917
Yak list
Peter van Dijk edited this page May 5, 2021
·
46 revisions
With reference to https://en.wiktionary.org/wiki/yak_shaving, sometimes somebody will run into something that 'could be nicer' but does not warrant an issue ticket. Instead, we note those things here. Pull requests fixing these things are welcomed! Feel free to add to this list.
The yaks are numbered so a PR can easily reference them.. Please use ~bla bla~
to strike out finished items, adding 'PR #1234after the closing
~`.
-
(auth at least)PR #7005./configure --help
has alignment issues -
(all products)PR #702615:10Z <lieter> another yak I have with confige is our inconsistent use of --enable-X and --with-X 15:11Z <lieter> --enable are _our_ programs's options and --with-X should be external deps
-
(auth at least) README has instructions for Debian 8.0, should not say '.0' and should be updated for 9PR #7027 - recursor and dnsdist rely on symlinks into the 'main' pdns source tree. Travis should check for dangling symlinks. PR #7028
-
figure out Travis/python/SSL warnings and do something about themPR #7106 - generally improve quality of Travis logging output
- in 49f72da134c234603abc5d270f73ea6191dceeff, we imported
timegm
from dietlibc, presumably(!) because Solaris does not have it. Figure out if that is still relevant today, otherwise, get rid of it. - in https://dnsdist.org/reference/config.html?highlight=setup, there is a visible
:ref:
(to "Healthcheck") that should be a link - document that dnsdist
newServer()
returns the server object - parallelize Travis builds or at least check if this is still applicable (also see here)
- check whether
_blank
is an issue in our code (targetblank) - LGTM alerts
- Make sure LGTM only builds the right products on the right branches (i.e. no auth builds on a rec branch)
- We use
unsigned int
and other int types without size identifiers. It would be nice to switch to properly typed integers (likeuint32_t
). - Remove all references to GOST (some already done, some in #7187, more to do)
- pdns-4.1.5.tar.gz accidentally contains
regression-tests/zones/unit.test
, perhaps other undesired files as well. Figure out a way to notice this (a list in git?) - some of the Lua examples in the docs, and example *.lua files in the tree, use
print()
, they should usepdnslog
- fix this style nit: https://github.com/PowerDNS/pdns/pull/6531#issuecomment-384242153
pdns/docs/http-api/tsigkey.rst:63: WARNING: Definition list ends without a blank line; unexpected unindent.
- decide if we want to do anything (document?) about the
universe
thing in https://mailman.powerdns.com/pipermail/pdns-users/2018-December/025685.html rec_control --version
- Flake8 testing
- ifurlup (Python function, in Preset variables) it's a Lua function
- https://doc.powerdns.com/authoritative/http-api/cryptokey.html#cryptokey - the underlying swagger yaml says keytype is an enum, but the docs do not reflect that
- https://doc.powerdns.com/authoritative/backends/oracle.html - the Warning is in the middle of a sentence
- sdig does not report parser errors. For example, a reply packet (in hex here)
9a0e83830001000000010001023432033235330331353802393807696e2d61646472046172706100000c0001c0170006000100002a1a002a017a046172696e036e65740007646e732d6f7073c1f6783962e60000070800000384000a8c0000002a300000291000000000000000
has a forward label compression reference that is caught by dnsname.cc:130 (-> 130 throw std::range_error("Found a forward reference during label decompression");
) but sdig throws that exception away, somehow -
checking for library containing mdb_env_open... no
does not abort auth./configure
- recursor
--enable-unit-tests --enable-ubsan
: testrunner fails to link (undefined reference to ``typeinfo for RecursorLua4'
) unless you addSANITIZER_FLAGS='-fno-sanitize=vptr'
Please also read the PowerDNS Documentation that is available from https://doc.powerdns.com/