Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: coverity 20250217 #15168

Merged
merged 2 commits into from
Feb 17, 2025
Merged

rec: coverity 20250217 #15168

merged 2 commits into from
Feb 17, 2025

Conversation

omoerbeek
Copy link
Member

Short description

A couple cases of complaints that should be eliminated by reducing the scope of a lock plus one "you can use a ref".

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek
Coverity 1591604 Use of auto that causes a copy
89a0982
@omoerbeek
This should eliminate a dozen or so Coverity warnigs
776c2fe 
For example:

1591605 Data race condition

5. missing_lock: Accessing g_lowercaseOutgoing without holding lock LockGuarded<std::shared_ptr<std::unordered_map<DNSName, SyncRes::AuthDomain, std::hash<DNSName>, std::equal_to<DNSName>, std::allocator<std::pair<DNSName const, SyncRes::AuthDomain> > > > >.d_mutex. Elsewhere, g_lowercaseOutgoing is written to with LockGuarded.d_mutex held 1 out of 1 times.
@omoerbeek omoerbeek added the rec label Feb 17, 2025
@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Feb 17, 2025
miodvallat
miodvallat approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverito ergo sum

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13365842267

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 21 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 64.485%
Files with Coverage Reduction New Missed Lines %
pdns/validate.cc 1 68.24%
pdns/recursordist/aggressive_nsec.cc 2 65.8%
pdns/sstuff.hh 2 56.83%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/remote_logger.cc 3 57.4%
pdns/stubresolver.cc 3 77.02%
pdns/recursordist/test-syncres_cc1.cc 7 89.3%
Totals Coverage Status
Change from base Build 13345043114: 2.3%
Covered Lines: 127603
Relevant Lines: 166875
💛 - Coveralls

@omoerbeek omoerbeek merged commit deb6d31 into PowerDNS:master Feb 17, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

@miodvallat miodvallat miodvallat approved these changes

Assignees
No one assigned
Labels
rec
Projects
None yet
Milestone
rec-5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@omoerbeek @coveralls @rgacogne @miodvallat