Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: reload proxy settings on rec_control reload-acls #15167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

Fixes #14096

I should spend some time to write a test framework for the various config reload cases.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13365073820

Details

  • 56 of 64 (87.5%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+2.3%) to 64.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec-rust-lib/cxxsupport.cc 0 2 0.0%
pdns/recursordist/rec-main.cc 44 50 88.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
pdns/recursordist/rec-rust-lib/cxxsupport.cc 1 75.64%
pdns/sstuff.hh 2 56.83%
pdns/iputils.cc 3 56.07%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/stubresolver.cc 3 77.02%
pdns/signingpipe.cc 5 83.11%
pdns/recursordist/test-syncres_cc1.cc 11 89.45%
Totals Coverage Status
Change from base Build 13345043114: 2.3%
Covered Lines: 127638
Relevant Lines: 166914

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rec_control reload-acls also should reload proxy-protocol-from
2 participants