Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: add support for dnstap new http_protocol field #15151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chbruyand
Copy link
Member

Short description

This fix #15108

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13306660380

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 18 (77.78%) changed or added relevant lines in 2 files are covered.
  • 50 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.006%) to 64.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-actions-factory.cc 11 15 73.33%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/dnsdistdist/dnsdist-backend.cc 1 66.19%
pdns/pollmplexer.cc 1 83.66%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/communicator.cc 3 71.85%
pdns/recursordist/syncres.cc 3 80.21%
pdns/iputils.hh 3 78.23%
pdns/iputils.cc 3 56.99%
pdns/communicator.hh 3 77.78%
pdns/signingpipe.cc 5 84.45%
Totals Coverage Status
Change from base Build 13305454892: -0.006%
Covered Lines: 128172
Relevant Lines: 167040

💛 - Coveralls

@rgacogne
Copy link
Member

A small nit from clang-tidy and this should be good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Support dnstap's HttpProtocol field
3 participants