Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Bump the required version of meson to 1.3 #15149

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rgacogne
Copy link
Member

Short description

Since we now use the follow_symlinks option of install_data(). We could probably make it work with older versions but a quick look at what distributions provide suggests that 1.2.1 or 1.3.0 is practically the same amount of pain.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Since we now use the `follow_symlinks` option of `install_data()`.
We could probably make it work with older versions but a quick look
at what distributions provide suggests that 1.2.1 or 1.3.0 is
practically the same amount of pain.
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but don't think I am endorsing 1.3 mesonry!

@rgacogne rgacogne merged commit 88e27d5 into PowerDNS:master Feb 13, 2025
83 checks passed
@rgacogne rgacogne deleted the ddist-meson-min-version branch February 13, 2025 11:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13306073218

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 41 unchanged lines in 11 files lost coverage.
  • Overall coverage remained the same at 64.717%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 66.19%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/communicator.cc 3 71.85%
pdns/iputils.hh 3 78.18%
pdns/iputils.cc 3 56.99%
pdns/communicator.hh 3 77.04%
modules/gpgsqlbackend/spgsql.cc 3 68.18%
pdns/recursordist/rec-tcp.cc 5 65.28%
Totals Coverage Status
Change from base Build 13305454892: 0.0%
Covered Lines: 128183
Relevant Lines: 167042

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants