Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix console ("client mode") on non-default address or port #15148

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rgacogne
Copy link
Member

Short description

The console address and port were not properly set in client mode, so dnsdist tried to connect to the default console address and port.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The console address and port were not properly set in client mode,
so `dnsdist` tried to connect to the default console address and port.
@rgacogne rgacogne merged commit 9245a0a into PowerDNS:master Feb 13, 2025
83 checks passed
@rgacogne rgacogne deleted the ddist-unbreak-console branch February 13, 2025 11:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13306021179

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 51 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.692%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 66.19%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/recursor_cache.cc 1 84.16%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/communicator.cc 3 71.85%
pdns/recursordist/syncres.cc 3 80.05%
pdns/iputils.hh 3 78.23%
pdns/communicator.hh 3 77.04%
pdns/signingpipe.cc 5 83.38%
Totals Coverage Status
Change from base Build 13305454892: -0.03%
Covered Lines: 128161
Relevant Lines: 167036

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants