-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: allow use of meson to create dist file #15076
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a6807a3
Fix gen-version path
omoerbeek 8756214
Add dist script
omoerbeek efdcbb5
Replace a few symlinks with actual files
omoerbeek ec409ef
replace symlinks with actual files
omoerbeek 323133f
Fix version number for Meson build
omoerbeek 1e256fe
Run autoconf -vi to create configure script (so that autotool builds …
omoerbeek 3b87737
Include dnslabeltext.cc in trabal, otherwise ragel becomes a build de…
omoerbeek 805596a
Typo in comment
omoerbeek 28e0d7a
Update requirements, fetch effective_tld_names.dat
omoerbeek 6f2c896
Skip a few files and dirs in the meson dist tarball
omoerbeek 4b02618
Add a check to see if gen-version still is up-to-date
omoerbeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,2 @@ | ||
gen_version_prog = find_program('gen-version', dirs: product_source_dir / 'builder-support', required: true) | ||
gen_version_prog_res = run_command(gen_version_prog, check: true) | ||
product_version = gen_version_prog_res.stdout().strip() | ||
product_version = meson.project_version() | ||
conf.set_quoted('VERSION', product_version, description: 'Version') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Caddyfile export-ignore | ||
/README.md export-ignore | ||
docs export-ignore | ||
examples export-ignore | ||
make-ext-symlinks.py export-ignore | ||
recursor-lsan.supp export-ignore | ||
recursor-tsan.supp export-ignore | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
This program is free software; you can redistribute it and/or modify | ||
it under the terms of version 2 of the GNU General Public License as | ||
published by the Free Software Foundation. | ||
|
||
In addition, for the avoidance of any doubt, permission is granted to | ||
link this program with OpenSSL and to (re)distribute the binaries | ||
produced as the result of such linking. | ||
|
||
This program is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU General Public License for more details. | ||
|
||
You should have received a copy of the GNU General Public License | ||
along with this program; if not, write to the Free Software | ||
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
#!/bin/sh | ||
if [ ! -z "${BUILDER_VERSION}" ]; then | ||
printf ${BUILDER_VERSION} | ||
exit 0 | ||
fi | ||
|
||
VERSION="unknown" | ||
|
||
DIRTY="" | ||
git status | grep -q clean || DIRTY='.dirty' | ||
|
||
# Special environment variable to signal that we are building a release, as this | ||
# has consequenses for the version number. | ||
if [ "${IS_RELEASE}" = "YES" ]; then | ||
TAG="$(git describe --tags --exact-match 2> /dev/null | cut -d- -f 2-)" | ||
if [ -n "${TAG}" ]; then | ||
# We're on a tag | ||
echo "${TAG}${DIRTY}" > .version | ||
printf "${TAG}${DIRTY}" | ||
exit 0 | ||
fi | ||
echo 'This is not a tag, either tag this commit or do not set $IS_RELEASE' >&2 | ||
exit 1 | ||
fi | ||
|
||
# | ||
# Generate the version number based on the branch | ||
# | ||
if [ ! -z "$(git rev-parse --abbrev-ref HEAD 2> /dev/null)" ]; then | ||
if [ -n "${BUILDER_MODULES}" ]; then | ||
match=${BUILDER_MODULES} | ||
[ $match = "authoritative" ] && match='auth' | ||
[ $match = "recursor" ] && match='rec' | ||
GIT_VERSION="$(git describe --match=${match}-* --tags | cut -d- -f2-)" | ||
if [ $(echo ${GIT_VERSION} | awk -F"-" '{print NF-1}') = '3' ]; then | ||
# A prerelease happened before | ||
LAST_TAG="$(echo ${GIT_VERSION} | cut -d- -f1-2)" | ||
COMMITS_SINCE_TAG="$(echo ${GIT_VERSION} | cut -d- -f3)" | ||
GIT_HASH="$(echo ${GIT_VERSION} | cut -d- -f4)" | ||
elif [ $(echo ${GIT_VERSION} | awk -F"-" '{print NF-1}') = '1' ]; then | ||
# Exactly on a pre-release | ||
LAST_TAG="$(echo ${GIT_VERSION} | cut -d- -f1-2)" | ||
else | ||
LAST_TAG="$(echo ${GIT_VERSION} | cut -d- -f1)" | ||
COMMITS_SINCE_TAG="$(echo ${GIT_VERSION} | cut -d- -f2)" | ||
GIT_HASH="$(echo ${GIT_VERSION} | cut -d- -f3)" | ||
fi | ||
fi | ||
|
||
if [ -z "${GIT_VERSION}" ]; then | ||
# BUILDER_SUPPORT has more than one product listed, fall back to the 0.0.0 logic | ||
|
||
# We used 0.0.XXXXgHASH for master in the previous incarnation of our build pipeline. | ||
# This now becomes 0.0.XXXX.0.gHASH, as 0.0.0.XXXX.gHASH (which is more correct) | ||
# would break upgrades for those running master | ||
# This _should_ be ok for forever is we stick to X.Y.Z for version numbers | ||
LAST_TAG=0.0 | ||
COMMITS_SINCE_TAG="$(git rev-list --count 12c868770afc20b6cc0da439d881105151d557dd..HEAD 2> /dev/null).0" | ||
[ "${COMMITS_SINCE_TAG}" = ".0" ] && COMMITS_SINCE_TAG=0.0 | ||
GIT_HASH="g$(git rev-parse HEAD | cut -c1-10 2> /dev/null)" | ||
fi | ||
|
||
BRANCH=".$(git rev-parse --abbrev-ref HEAD | perl -p -e 's/[^[:alnum:]]//g;')" | ||
|
||
TAG="$(git describe --tags --exact-match 2> /dev/null | cut -d- -f 2-)" | ||
if [ -n "${TAG}" ]; then # We're exactly on a tag | ||
COMMITS_SINCE_TAG="0" | ||
GIT_HASH="g$(git show --no-patch --format=format:%h HEAD 2>/dev/null)" | ||
if [ -z "$GIT_HASH" ]; then | ||
GIT_HASH="g$(git show --format=format:%h HEAD | head -n1)" | ||
fi | ||
fi | ||
|
||
VERSION="${LAST_TAG}.${COMMITS_SINCE_TAG}${BRANCH}.${GIT_HASH}${DIRTY}" | ||
fi | ||
|
||
printf $VERSION |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/bin/sh -e | ||
|
||
echo Running meson-dist-script | ||
echo PWD=$(pwd) | ||
echo MESON_SOURCE_ROOT=$MESON_SOURCE_ROOT | ||
echo MESON_PROJECT_DIST_ROOT=$MESON_PROJECT_DIST_ROOT | ||
|
||
cd "$MESON_PROJECT_DIST_ROOT" | ||
|
||
# Get all symlinks | ||
symlinks=$(find . -type l) | ||
|
||
# Get the dereffed symbolic links (the actual files being pointed to) from the source dir | ||
# Extract them over the existing symbolic links | ||
tar -C "$MESON_SOURCE_ROOT" -hcf - $symlinks | tar -xf - -C "$MESON_PROJECT_DIST_ROOT" | ||
|
||
# Run autoconf for people using autotools to build, this creates a configure script with VERSION set | ||
echo Running autoreconf -vi so distfile is still usable for autotools building | ||
# Run autoconf for people using autotools to build, this creates a configure sc | ||
autoreconf -vi | ||
|
||
# Generate man pages | ||
cd "$MESON_PROJECT_BUILD_ROOT" | ||
ninja man-pages | ||
cp -vp rec-man-pages/*.1 "$MESON_PROJECT_DIST_ROOT" | ||
|
||
rm -rf "$MESON_PROJECT_DIST_ROOT"/autom4te.cache | ||
|
||
|
||
# Generate a few files to reduce build dependencies | ||
echo 'If the below command generates an error, remove dnslabeltext.cc from source dir (remains of an autotools build?) and start again with a clean meson setup' | ||
ninja librec-dnslabeltext.a.p/dnslabeltext.cc | ||
cp -vp librec-dnslabeltext.a.p/dnslabeltext.cc "$MESON_PROJECT_DIST_ROOT" | ||
echo 'If the below command generates an error, remove effective_tld_names.dat and pubsuffix.cc from source dir (remains of an autotools build?) and start again with a clean meson setup' | ||
ninja effective_tld_names.dat | ||
cp -vp effective_tld_names.dat "$MESON_PROJECT_DIST_ROOT" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#!/bin/sh | ||
|
||
if [ "$1" = "get-vcs" ]; then | ||
builder-support/gen-version | ||
elif [ "$1" = "set-dist" ]; then | ||
$MESONREWRITE -V --sourcedir="$MESON_PROJECT_DIST_ROOT" kwargs set project / version "$2" | ||
else | ||
exit 1 | ||
fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth keeping these in and setting it up so that meson sanitizer builds automatically use them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point yes, but for now my goal is to produce a valid distfile. Extra features can be done later.