Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.8.x: Detect and dismiss truncated UDP responses from a backend #13598

Merged
merged 2 commits into from
Dec 14, 2023
Merged

dnsdist-1.8.x: Detect and dismiss truncated UDP responses from a backend #13598

merged 2 commits into from
Dec 14, 2023

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Dec 12, 2023 •
edited by chbruyand
Loading

Short description

Backport of #13536 to rel/dnsdist-1.8.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne
dnsdist: Detect and dismiss truncated UDP responses from a backend
5def25e 
Until now we would not have detected if the response was larger than
our buffer (4096 bytes or larger in some cases), which could have
led to parsing errors or even forwarding a corrupted response.

(cherry picked from commit 17a0b06)
@rgacogne
dnsdist: Explain to clang-tidy that resizing a moved vector is fine
52e0c82 
(cherry picked from commit c0391c2)
@rgacogne rgacogne added this to the dnsdist-1.8.x milestone Dec 12, 2023
@rgacogne rgacogne merged commit c8a4ab3 into PowerDNS:rel/dnsdist-1.8.x Dec 14, 2023
@rgacogne rgacogne deleted the ddist18-13536 branch December 14, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @chbruyand