From b3bb42281a737a6382519042128cb8c3677beef3 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 13 Feb 2025 11:48:23 +0100 Subject: [PATCH] dnsdist: Fix console ("client mode") on non-default address or port The console address and port were not properly set in client mode, so `dnsdist` tried to connect to the default console address and port. --- pdns/dnsdistdist/dnsdist-lua.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc index 464f0192251d..29e0d19491e8 100644 --- a/pdns/dnsdistdist/dnsdist-lua.cc +++ b/pdns/dnsdistdist/dnsdist-lua.cc @@ -1171,14 +1171,15 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck) setLuaSideEffect(); ComboAddress local(str, 5199); - if (client || configCheck) { - return; - } - dnsdist::configuration::updateRuntimeConfiguration([local](dnsdist::configuration::RuntimeConfiguration& config) { config.d_consoleServerAddress = local; config.d_consoleEnabled = true; }); + + if (client || configCheck) { + return; + } + #if defined(HAVE_LIBSODIUM) || defined(HAVE_LIBCRYPTO) if (dnsdist::configuration::isImmutableConfigurationDone() && dnsdist::configuration::getCurrentRuntimeConfiguration().d_consoleKey.empty()) { warnlog("Warning, the console has been enabled via 'controlSocket()' but no key has been set with 'setKey()' so all connections will fail until a key has been set");