Fix custom list in currencies

PostScripton · Jul 25, 2022 · 2c55be1 · 2c55be1
1 parent 457d64c
commit 2c55be1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 137 deletions.
diff --git a/src/Currency.php b/src/Currency.php
@@ -26,6 +26,13 @@ class Currency
     public const LIST_CUSTOM = 'custom';
     public const LIST_CONFIG = 'config';
 
+    public const LISTS = [
+        self::LIST_ALL,
+        self::LIST_POPULAR,
+        self::LIST_CUSTOM,
+        self::LIST_CONFIG,
+    ];
+
     private const CONFIG_LIST = 'money.currency_list';
     private const CONFIG_CUSTOM = 'money.custom_currencies';
 
@@ -192,21 +199,13 @@ public static function getCurrencies(): array
 
     public static function isIncorrectList(string $list): bool
     {
-        return !in_array(
-            $list,
-            [
-                self::LIST_ALL,
-                self::LIST_POPULAR,
-                self::LIST_CONFIG,
-                self::LIST_CONFIG,
-            ]
-        );
+        return !in_array($list, self::LISTS);
     }
 
     public static function setCurrencyList(string $list = self::LIST_POPULAR): void
     {
         if (self::isIncorrectList($list)) {
-            $list = self::LIST_POPULAR;
+            throw new CurrencyListConfigException($list);
         }
         self::$list = $list;
 

diff --git a/tests/Feature/CurrencyListsTest.php b/tests/Feature/CurrencyListsTest.php