Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Background music #55

Closed
wants to merge 5 commits into from

Conversation

networkfusion
Copy link
Collaborator

Description

Adds basic BGM. Help is required to refine it.

Motivation and Context

It is nice to have some background music.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@networkfusion networkfusion added the enhancement New feature or request label Oct 14, 2023
@networkfusion networkfusion added the help wanted Extra attention is needed label Oct 14, 2023
@Polprzewodnikowy
Copy link
Owner

I'm hesitant to allow playing MP3 files outside of the player screen. minimp3 unfortunately has rather big load on the CPU and browsing files would be rather choppy. Maybe someday if we have MP3 decoding done on the RSP then it would be a viable option.

@networkfusion
Copy link
Collaborator Author

I'm hesitant to allow playing MP3 files outside of the player screen. minimp3 unfortunately has rather big load on the CPU and browsing files would be rather choppy. Maybe someday if we have MP3 decoding done on the RSP then it would be a viable option.

In that case, I will close this PR for now. We could implement action sounds and would be nice to have some "out the box" BGM, but that is for a feature request.

Thanks for the input.

@Polprzewodnikowy
Copy link
Owner

We can easily add files in the dragonfs so adding action sounds should be very easy with libdragon tooling available now. Only problem (at least for me) is sourcing sound effects with permissible license. Or just make some myself.

@networkfusion
Copy link
Collaborator Author

We can (and should) ask for someone to contribute that on the brew discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants