Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Uncompressed Key #910

Merged
merged 21 commits into from
Feb 12, 2024
Merged

Added support for Uncompressed Key #910

merged 21 commits into from
Feb 12, 2024

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Feb 7, 2024

Describe your changes

Added support for Uncompressed Key.

Gauthamastro
Gauthamastro previously approved these changes Feb 7, 2024
pallets/thea/src/lib.rs Show resolved Hide resolved
@zktony zktony added the A0-PleaseReview Pull request needs code review. label Feb 7, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 8, 2024
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 10, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (5188341) 40.27% compared to head (39cc1c8) 39.74%.
Report is 14 commits behind head on Develop.

Files Patch % Lines
pallets/thea/src/lib.rs 63.79% 21 Missing ⚠️
pallets/ocex/src/validator.rs 0.00% 17 Missing ⚠️
pallets/thea/src/weights.rs 20.00% 12 Missing ⚠️
rpc/swap/src/lib.rs 0.00% 11 Missing ⚠️
primitives/orderbook/src/types.rs 47.36% 10 Missing ⚠️
pallets/ocex/src/lib.rs 72.72% 9 Missing ⚠️
pallets/thea-executor/src/lib.rs 50.00% 6 Missing ⚠️
primitives/polkadex/src/assets.rs 42.85% 4 Missing ⚠️
misc/crowdloan-verifier/src/main.rs 0.00% 3 Missing ⚠️
pallets/ocex/src/aggregator.rs 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #910      +/-   ##
===========================================
- Coverage    40.27%   39.74%   -0.53%     
===========================================
  Files           64       63       -1     
  Lines         3973     4036      +63     
===========================================
+ Hits          1600     1604       +4     
- Misses        2373     2432      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pallets/thea/src/tests.rs Outdated Show resolved Hide resolved
pallets/thea/src/tests.rs Outdated Show resolved Hide resolved
pallets/thea/src/tests.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Feb 12, 2024
@Gauthamastro Gauthamastro merged commit fb8c700 into Develop Feb 12, 2024
3 checks passed
@Gauthamastro Gauthamastro deleted the zk-uncomp-key branch February 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants