Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Orderbook Offchain RPC #886

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

Gauthamastro
Copy link
Member

Describe your changes

The recent substrate upgrade broke our Orderbook offchain RPCs. This PR fixes that.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@Gauthamastro Gauthamastro requested a review from zktony December 5, 2023 07:24
@Gauthamastro Gauthamastro self-assigned this Dec 5, 2023
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Dec 5, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 5, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (d803ec1) 37.52% compared to head (9eddb17) 36.92%.

Files Patch % Lines
pallets/ocex/rpc/src/lib.rs 0.00% 104 Missing ⚠️
pallets/ocex/src/rpc.rs 0.00% 6 Missing ⚠️
runtimes/mainnet/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #886      +/-   ##
===========================================
- Coverage    37.52%   36.92%   -0.60%     
===========================================
  Files           62       62              
  Lines         3750     3810      +60     
===========================================
  Hits          1407     1407              
- Misses        2343     2403      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zktony zktony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Gauthamastro Gauthamastro merged commit 1761932 into Develop Dec 6, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the gj/fix-offchain-rpc branch December 6, 2023 03:56
@Gauthamastro Gauthamastro restored the gj/fix-offchain-rpc branch December 6, 2023 05:03
Gauthamastro added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants