Illinois Aid to the Aged, Blind or Disabled (AABD) #5853

hua7450 · 2025-04-08T21:44:24Z

codecov · 2025-04-08T22:25:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (73134e0) to head (e88cc5b).
Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #5853    +/-   ##
========================================
  Coverage   99.09%   99.10%            
========================================
  Files        2775     2798    +23     
  Lines       40101    40453   +352     
  Branches      179      180     +1     
========================================
+ Hits        39740    40090   +350     
- Misses        327      328     +1     
- Partials       34       35     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PavelMakarchuk

Just some formatting for the parameters

policyengine_us/parameters/gov/states/il/dhs/aabd/asset/disregard/additional.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/asset/vehicle_exemption/amount.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/asset/vehicle_exemption/count.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/income/exemption/blind.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/income/exemption/flat.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/area/area_1.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/area/area_2.yaml

…and tests

into hua7450/issue5844

...riables/gov/states/il/dhs/aabd/income/earned/il_aabd_earned_income_after_exemption_person.py

PavelMakarchuk · 2025-04-14T20:44:49Z

...ngine_us/variables/gov/states/il/dhs/aabd/income/expense/il_aabd_expense_exemption_person.py

+        "https://www.law.cornell.edu/regulations/illinois/Ill-Admin-Code-tit-89-SS-113.125",
+    )
+
+    # def formula(person, period, parameters):


remove if not relevant

Lets make a list for exemptions:

state_withheld_income_tax employee_social_security_tax il_aabd_child_care_expense_exemption

Leave the other as comments

Crease il_aabd_child_care_expense_exemption.py use childcare_expenses

PavelMakarchuk · 2025-04-14T20:47:24Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/utility/il_utility_allowance.py

+        expense_types = p.utility.utility_types
+        sum_of_allowances = sum(
+            [
+                p.utility[expense.replace("_expense", "")][area][capped_size]
+                for expense in expense_types
+            ]
+        )  # a household may not have all of the expenses, at this point, I summed all of them
+
+        return sum_of_allowances


do we not just get the breakdown parameter by area and unit size here?

The list contains all possible utilities, such as bottled gas, coal, cooking fuel, fuel oil, metered gas, and it's super unlikely that a single household would use all those utility types at once.

policyengine_us/variables/gov/states/il/dhs/aabd/asset/il_aabd_asset_eligible.py

...ngine_us/tests/policy/baseline/gov/states/il/dhs/aabd/payment/il_aabd_utility_allowance.yaml

PavelMakarchuk · 2025-04-14T20:49:58Z

policyengine_us/tests/policy/baseline/gov/states/il/dhs/aabd/il_aabd_area.yaml

+  output:
+    il_aabd_area: AREA_2
+
+# - name: Case 3, default in area 1.  


why is commented?

This test case causes an interesting error: when I intentionally omit county_str as an input, the output is AREA_6, which is weird because I set the default value to AREA_1.

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/utility/water.yaml

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/utility/utility_types.yaml

into hua7450/issue5844

...s/variables/gov/states/il/dhs/aabd/eligibility/il_aabd_immigration_status_eligible_person.py

policyengine_us/parameters/gov/states/il/dhs/aabd/income/sources/unearned.yaml

...riables/gov/states/il/dhs/aabd/income/earned/il_aabd_earned_income_after_exemption_person.py

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/personal_allowance/active.yaml

PavelMakarchuk · 2025-04-17T22:02:55Z

...us/variables/gov/states/il/dhs/aabd/payment/personal_allowance/il_aabd_personal_allowance.py

+        size = person.spm_unit("spm_unit_size", period)
+        capped_size = clip(size, 1, 8)
+        is_bedfast = person("il_aabd_is_bedfast", period)
+        return where(is_bedfast, p.bedfast[capped_size], p.active[capped_size])


lets make this amount * unit size
Legal code is very ambiguous here but o3 thinks the same:
https://chatgpt.com/c/680179b4-7640-8011-b2f3-a9243590ae90

policyengine_us/variables/gov/states/il/dhs/aabd/payment/shelter/il_aabd_shelter_allowance.py

into hua7450/issue5844

PavelMakarchuk · 2025-04-21T12:55:03Z

policyengine_us/parameters/gov/states/il/dhs/aabd/income/exemption/child_care.yaml

+    amount:
+      1991-01-01: 128
+  - threshold:
+      1991-01-01: 25 # In legal code it is 100 hours, we use weekly hours worked so divide by 4


Suggested change

1991-01-01: 25 # In legal code it is 100 hours, we use weekly hours worked so divide by 4

1991-01-01: 25 # 100 hours worked monthly

PavelMakarchuk · 2025-04-21T12:56:36Z

policyengine_us/parameters/gov/states/il/dhs/aabd/payment/personal_allowance/active.yaml

+    # DHS legal code version displays the personal allowance as once value 
+    # allowance type is not unconditional


Suggested change

# DHS legal code version displays the personal allowance as once value

# allowance type is not unconditional

# DHS legal code version displays the personal allowance as an aggregate value

# allowance type is conditional

If it conditional (or not unconditional) - do we need to split it out then?

PavelMakarchuk · 2025-04-21T12:59:06Z

policyengine_us/variables/gov/states/il/dhs/aabd/asset/il_aabd_countable_vehicles_value.py

+from policyengine_us.model_api import *
+
+
+class il_aabd_countable_vehicles_value(Variable):


Suggested change

class il_aabd_countable_vehicles_value(Variable):

class il_aabd_countable_vehicle_value(Variable):

PavelMakarchuk · 2025-04-21T12:59:38Z

policyengine_us/variables/gov/states/il/dhs/aabd/asset/il_aabd_vehicle_is_essential.py

+    value_type = bool
+    entity = SPMUnit
+    definition_period = MONTH
+    label = "Whether the household has essential use vehicle under the Illinois Aid to the Aged, Blind or Disabled (AABD)"


Suggested change

label = "Whether the household has essential use vehicle under the Illinois Aid to the Aged, Blind or Disabled (AABD)"

label = "Whether the household has a vehicle which is considered essential under the Illinois Aid to the Aged, Blind or Disabled (AABD)"

PavelMakarchuk · 2025-04-21T13:01:05Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/il_aabd_total_needs.py

+    entity = Person
+    label = "Illinois Aid to the Aged, Blind or Disabled (AABD) total needs"
+    unit = USD
+    definition_period = MONTH


could you leave a reference here?

PavelMakarchuk · 2025-04-21T13:01:18Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/il_aabd_total_needs.py

+from policyengine_us.model_api import *
+
+
+class il_aabd_total_needs(Variable):


Suggested change

class il_aabd_total_needs(Variable):

class il_aabd_need_standard_person(Variable):

PavelMakarchuk · 2025-04-21T13:01:43Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/il_aabd_total_needs.py

+class il_aabd_total_needs(Variable):
+    value_type = float
+    entity = Person
+    label = "Illinois Aid to the Aged, Blind or Disabled (AABD) total needs"


Suggested change

label = "Illinois Aid to the Aged, Blind or Disabled (AABD) total needs"

label = "Illinois Aid to the Aged, Blind or Disabled (AABD) need standard for each person"

PavelMakarchuk · 2025-04-21T13:05:28Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/utility/il_utility_allowance.py

+                p.utility[expense.replace("_expense", "")][area][capped_size]
+                for expense in expense_types
+            ]
+        )  # a household may not have all of the expenses, at this point, I summed all of them


Suggested change

) # a household may not have all of the expenses, at this point, I summed all of them

)

PavelMakarchuk · 2025-04-21T13:06:00Z

policyengine_us/variables/gov/states/il/dhs/aabd/payment/utility/il_utility_allowance.py

+        capped_size = clip(size, 1, 19)
+        area = person.household("il_aabd_area", period)
+        expense_types = p.utility.utility_types
+        sum_of_allowances = sum(


Suggested change

sum_of_allowances = sum(

# Households may have more than one applicable utility allowance type

sum_of_allowances = sum(

draft for non-financial eligibility

2321c9e

Ziming added 2 commits April 9, 2025 16:47

add asset and income exemption

c751819

add utility allowance

34bdd51

PavelMakarchuk requested changes Apr 10, 2025

View reviewed changes

Ziming added 9 commits April 10, 2025 18:21

add Institutional Status, add has_essential_vehicles, adjust formula …

d7da4fd

…and tests

format

02732bc

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

7e2e05e

into hua7450/issue5844

minor

5ea7101

add utility parameter and formula

e88cc5b

add grant amount parameter and computation formula

395f834

format

28fd306

add personal allowance

fac8360

change to person level

231928b

hua7450 requested a review from PavelMakarchuk April 14, 2025 20:09

PavelMakarchuk requested changes Apr 14, 2025

View reviewed changes

Ziming added 2 commits April 15, 2025 01:11

add shelter allowance

05f922f

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

5700271

into hua7450/issue5844

hua7450 self-assigned this Apr 15, 2025

PavelMakarchuk requested changes Apr 17, 2025

View reviewed changes

Ziming added 2 commits April 21, 2025 01:51

many adjustments

2308e7c

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

6045dd6

into hua7450/issue5844

PavelMakarchuk requested changes Apr 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Illinois Aid to the Aged, Blind or Disabled (AABD) #5853

Illinois Aid to the Aged, Blind or Disabled (AABD) #5853

hua7450 commented Apr 8, 2025

codecov bot commented Apr 8, 2025 •

edited

Loading

PavelMakarchuk left a comment

PavelMakarchuk Apr 14, 2025

PavelMakarchuk Apr 17, 2025

PavelMakarchuk Apr 14, 2025

hua7450 Apr 15, 2025

PavelMakarchuk Apr 14, 2025

hua7450 Apr 15, 2025

PavelMakarchuk Apr 17, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

PavelMakarchuk Apr 21, 2025

	1991-01-01: 25 # In legal code it is 100 hours, we use weekly hours worked so divide by 4
	1991-01-01: 25 # 100 hours worked monthly

		# DHS legal code version displays the personal allowance as once value
		# allowance type is not unconditional

		from policyengine_us.model_api import *


		class il_aabd_countable_vehicles_value(Variable):

	class il_aabd_countable_vehicles_value(Variable):
	class il_aabd_countable_vehicle_value(Variable):

	label = "Whether the household has essential use vehicle under the Illinois Aid to the Aged, Blind or Disabled (AABD)"
	label = "Whether the household has a vehicle which is considered essential under the Illinois Aid to the Aged, Blind or Disabled (AABD)"

		from policyengine_us.model_api import *


		class il_aabd_total_needs(Variable):

	class il_aabd_total_needs(Variable):
	class il_aabd_need_standard_person(Variable):

	label = "Illinois Aid to the Aged, Blind or Disabled (AABD) total needs"
	label = "Illinois Aid to the Aged, Blind or Disabled (AABD) need standard for each person"

	) # a household may not have all of the expenses, at this point, I summed all of them
	)

	sum_of_allowances = sum(
	# Households may have more than one applicable utility allowance type
	sum_of_allowances = sum(

Illinois Aid to the Aged, Blind or Disabled (AABD) #5853

Are you sure you want to change the base?

Illinois Aid to the Aged, Blind or Disabled (AABD) #5853

Conversation

hua7450 commented Apr 8, 2025

codecov bot commented Apr 8, 2025 • edited Loading

Codecov Report

PavelMakarchuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 8, 2025 •

edited

Loading