Build librdkafka with gssapi support for pip package, fixes #325 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
force-pushed
the
tkp/gssapi
branch
10 times, most recently
from
f7d5cf6 to
8f52943
Compare
timkpaine
added
part: dependencies
timkpaine
force-pushed
the
tkp/gssapi
branch
from
8f52943 to
0be7419
Compare
Signed-off-by: Tim Paine <Timothy.Paine@CubistSystematic.com>
alexddobkin
force-pushed
the
tkp/gssapi
branch
from
0be7419 to
66c4c14
Compare
robambalu
reviewed
Feb 12, 2025
| os.environ["ACLOCAL_PATH"] = f"{aclocal_path}:{os.environ.get('ACLOCAL_PATH', '')}" | ||
| except subprocess.CalledProcessError as e: | ||
| print("Error obtaining Homebrew prefix for autoconf-archive:", e) | ||
| aclocal_path = None |
timkpaine
commented
Feb 13, 2025
| except subprocess.CalledProcessError as e: | ||
| print("Error obtaining Homebrew prefix for autoconf-archive:", e) | ||
| aclocal_path = None | ||
| elif platform.system() != "Windows": |
There was a problem hiding this comment.
This will do this no matter the context, i think it probably makes more sense to only do this if we’re doing a manylinux build in the docker image since thats where the problem seems to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, builds
librdkafkawith GSSAPI support viacyrus-sasl, enabling this feature for our pip packages (currently this only works on our conda packages).No windows support for now as vcpkg krb5 does not support our static build, will make a separate ticket to track
xref: microsoft/vcpkg#40320