Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests #29

Open
5 tasks
hyfi06 opened this issue Mar 29, 2020 · 0 comments
Open
5 tasks

New tests #29

hyfi06 opened this issue Mar 29, 2020 · 0 comments

Comments

@hyfi06
Copy link

hyfi06 commented Mar 29, 2020

Estuve revisando las soluciones y encontré implementaciones incorrectas que pasan los test por que sugiero incluir los siguientes números para probar.

No primos

Números negativos

Como 1 no es primo, el test -1 pasa si se quita el signo.

  • -11
  • -6

Números flotantes

Si se redondean los números, quedan puros números no primos, con lo que se pasa el test pero no cubre todos los casos.

  • 2.4
  • 2.7
  • 11.5
hyfi06 added a commit to hyfi06/challenge-javascript-04 that referenced this issue Mar 29, 2020
@hyfi06
[Fix] Fix issue PlatziMaster#29 add new test
4eaec7d
hyfi06 added a commit to hyfi06/challenge-javascript-04 that referenced this issue Mar 29, 2020
@hyfi06
[Fix] Fix issue PlatziMaster#29 add new test
cc1235d
@hyfi06 hyfi06 mentioned this issue Mar 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyfi06