Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 support #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

1.17 support #22

wants to merge 3 commits into from

Conversation

Pjiwm
Copy link
Owner

@Pjiwm Pjiwm commented Jul 26, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Server currently runs on some versions of 1.16.x, Minecraft 1.17 is out and support for this version is needed.

Explain the details for making this change. What existing problem does the pull request solve?

Currently using this plugin on a 1.17 server will not work.
The current things are needed:

  • Plugin runs on 1.17.1
  • Plugin runs on 1.17
  • Plugin runs on 1.16.5
  • Plugin runs on 1.16.4
  • Plugin runs on 1.16.3
  • Plugin runs on 1.16.2
  • Plugin runs on 1.16.1
  • Plugin runs on 1.16

Test plan (required):
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request has visual changes.

  1. swap spigot.jar file of test server with needed version
  2. run server
  3. ececute plugins command and check if plugin is still green
  4. if on 1.17.x go on server to check if mob behavior is the same as on 1.16.x
    Closing issues
    [FEATURE]: 1.17 support #21

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant