Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: change output format #9

Open
moltar opened this issue Oct 1, 2018 · 2 comments
Open

Feature Request: change output format #9

moltar opened this issue Oct 1, 2018 · 2 comments
Assignees

Comments

@moltar
Copy link

moltar commented Oct 1, 2018

It's already possible to change the format of the binary content via an action:

'setFormat|jpg'

But the filename still remains of the original format.

E.g. if I need to always have a .jpg on the output, and input is .png after conversion, the contents of the file are JPEG, but the name still has .png.

Thanks!

@Barry-Fisher
Copy link
Contributor

Hi @moltar

Thanks for reporting this issue. Indeed, it appears that the setFormat is a special case where the target extension type needs to be respected. This currently isn't being handled by this module, however, it should be relatively straightforward to provide a fix.

Please leave this with me and I'll try to release a new minor version of this module this week that fixes this issue. I want to ensure that there is a matching test to ensure this is reproducible, stable and has test coverage now and in the future.

All the best,

Barry

@Barry-Fisher Barry-Fisher self-assigned this Oct 2, 2018
@patrickcate
Copy link

I have an image style that is generating placeholder 3x3 images, where this would be very useful. The source images are all jpegs, but the placeholder images as png's are about half the size of saving them as jpegs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants