Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated constant for HA 2024.1 #502

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Replace deprecated constant for HA 2024.1 #502

merged 2 commits into from
Jan 3, 2025

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Dec 31, 2023 •
edited
Loading

Had these in my logs:

2023-12-31 14:33:19.819 WARNING (MainThread) [homeassistant.components.camera] SUPPORT_ON_OFF was used from xiaomi_cloud_map_extractor, this is a deprecated constant which will be removed in HA Core 2025.1. Use CameraEntityFeature.ON_OFF instead, please create a bug report at https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor/issues
2023-12-31 14:33:19.823 WARNING (MainThread) [homeassistant.components.camera] SUPPORT_ON_OFF was used from xiaomi_cloud_map_extractor, this is a deprecated constant which will be removed in HA Core 2025.1. Use CameraEntityFeature.ON_OFF instead, please create a bug report at https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor/issues
2023-12-31 14:33:24.736 WARNING (MainThread) [homeassistant.helpers.entity] Entity camera.stofzuiger (<class 'custom_components.xiaomi_cloud_map_extractor.camera.VacuumCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature.ON_OFF: 1>, please create a bug report at https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

It was a straight forward fix.... 😄 Tested locally, runs fine. CameraEntityFeature has been around since 2022.5, so this should be non-breaking for older HA versions.

Docs: https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation/

@PiotrMachowski PiotrMachowski changed the base branch from master to dev December 31, 2023 14:11
@Ernst79 Ernst79 mentioned this pull request Jan 5, 2024
Closed
2 tasks
@gieljnssns
Copy link

Why doesn't get this merged?

MrHollowPS
MrHollowPS approved these changes Mar 13, 2024
View reviewed changes
Copy link

@MrHollowPS MrHollowPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. same patch i applied locally.

@Sdahl1234 Sdahl1234 mentioned this pull request Mar 14, 2024
Closed
2 tasks
@Quentame Quentame mentioned this pull request Oct 13, 2024
Closed
2 tasks
@mattdevo1
Copy link

@PiotrMachowski can we get this merged? I've applied this locally and it seems to be working fine.

@Aohzan
Copy link

Aohzan commented Dec 31, 2024 •
edited
Loading

@PiotrMachowski this PR is needed for 2025.1, tested on my side too
edit: see the comment on the #505 , next time if it's possible to merge before the beta released 🙏

@PiotrMachowski
Copy link
Owner

@Aohzan yeah, I know...

@PiotrMachowski PiotrMachowski merged commit 7790ea6 into PiotrMachowski:dev Jan 3, 2025
@PiotrMachowski
Copy link
Owner

thanks, @hmmbob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urosch urosch urosch approved these changes

@Quentame Quentame Quentame approved these changes

@MrHollowPS MrHollowPS MrHollowPS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hmmbob @gieljnssns @mattdevo1 @Aohzan @PiotrMachowski @MrHollowPS @Quentame @urosch