Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: support pd real cluster #2655

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 5, 2023

rely on tikv/pd#7493

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link

ti-chi-bot bot commented Dec 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp marked this pull request as ready for review December 5, 2023 05:59
Copy link

ti-chi-bot bot commented Dec 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

This pull request adds support for a real cluster in PD. The changes include adding a new pipeline job, a new pod template file, and a new Groovy script.

Potential problems:

  • The description is not very informative. It is just a reference to another PR. The author should provide more details about what this PR does and why it is needed.
  • The diff is not very clear. It would be helpful if the author provided more context about the changes and explained why they are necessary.
  • The new pipeline job and pod template file should be tested to ensure that they work correctly.

Fixing suggestions:

  • The author should provide a more detailed description of what this PR does and why it is necessary.
  • The author should provide more context about the changes in the diff and explain why they are necessary.
  • The author should test the new pipeline job and pod template file to ensure that they work correctly.

Copy link

ti-chi-bot bot commented Dec 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the information provided, this pull request adds support for a real cluster in pd. The changes include adding a new file pull_integration_realcluster_test.groovy, a new file pod-pull_integration_realcluster_test.yaml and a new file pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy. The changes seem to rely on another pull request (tikv/pd#7493) as mentioned in the pull request description.

One potential problem is that the pull request description does not provide enough information about what it is doing and why it is necessary. More detailed information about the changes and why they are necessary would make it easier for reviewers to evaluate the pull request and provide feedback.

One suggestion for fixing this is to provide a more detailed description of the changes and explain why they are necessary. Additionally, it would be helpful to include information about any testing that was done to ensure that the changes work as intended and do not introduce any new issues.

Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 8, 2023
Copy link

ti-chi-bot bot commented Dec 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-08 02:03:19.38832353 +0000 UTC m=+1752228.053549737: ☑️ agreed by purelind.

Copy link

ti-chi-bot bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 7163ba4 into PingCAP-QE:main Dec 8, 2023
@HuSharp HuSharp deleted the support_jenkins branch December 8, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants