-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd: support pd real cluster #2655
Conversation
Skipping CI for Draft Pull Request. |
pipelines/tikv/pd/latest/pod-pull_integration_realcluster_test.yaml
Outdated
Show resolved
Hide resolved
pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy
Outdated
Show resolved
Hide resolved
pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy
Outdated
Show resolved
Hide resolved
pipelines/tikv/pd/latest/pull_integration_realcluster_test.groovy
Outdated
Show resolved
Hide resolved
pipelines/tikv/pd/latest/pod-pull_integration_realcluster_test.yaml
Outdated
Show resolved
Hide resolved
This pull request adds support for a real cluster in PD. The changes include adding a new pipeline job, a new pod template file, and a new Groovy script. Potential problems:
Fixing suggestions:
|
One potential problem is that the pull request description does not provide enough information about what it is doing and why it is necessary. More detailed information about the changes and why they are necessary would make it easier for reviewers to evaluate the pull request and provide feedback. One suggestion for fixing this is to provide a more detailed description of the changes and explain why they are necessary. Additionally, it would be helpful to include information about any testing that was done to ensure that the changes work as intended and do not introduce any new issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rely on tikv/pd#7493