-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pilot 4952: Update cli listing command to allow user list specific files/folders under given root level folder #135
Conversation
app/utils/aggregated.py
Outdated
folder_name = temp_paths[2] | ||
else: | ||
folder_name = os.path.join(temp_paths[1], temp_paths[2]) | ||
folder_name = temp_paths[2] | ||
else: | ||
SrvErrorHandler.customized_handle(ECustomizedError.INVALID_NAMEFOLDER, True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to change the error message to reflect invlid folder structure for either name folder or shared folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs explicit error message for folder structure issue
Thanks for catching that! |
…les/folders under given root level folder (#135) * add [p] prefix for project folder when listing items under project * group itemprefix class with itemtype class * add double quotation when item name contains space * change enum type PROJECTFOLDER to SHAREDFOLDER * replace PROJECTFOLDER with SHAREDFOLDER * fixup test cases * fixup logic for different prefix * add prefix for name folder * bump up version to 3.0.0 * fixup test cases * fixup test cases * replace hardcoded string with enum value in test cases * remove the reference of project_folder * fixup test cases * update error message with new top level folder structure --------- Co-authored-by: zhiren <zzhan@indocresearch.org> Former-commit-id: 61f8a8b
Summary
Description
We used to list project folder together with user name folder. After this refactory, we would like to list them in different path, “shared” and “users”. Because there is no project folder concept in pilot, we will remove the [p] prefix while listing shared folders as well.
Implementation Detail
While listing items, user can use follow command to list items under shared folder or name folder:
Update help info based on above changes
Outcome
After refactor cli, user can list items seperately. When listing under project code directly. only shared and users are visible.
JIRA Issues
Pilot 4952
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
update old test cases