-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pilot 4951: Update the logic of upload command for root level folder(eg. users, shared) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andricDu
pushed a commit
that referenced
this pull request
May 23, 2024
…eg. users, shared) (#134) * add [p] prefix for project folder when listing items under project * group itemprefix class with itemtype class * add double quotation when item name contains space * change enum type PROJECTFOLDER to SHAREDFOLDER * replace PROJECTFOLDER with SHAREDFOLDER * fixup test cases * fixup logic for different prefix * add prefix for name folder * bump up version to 3.0.0 * fixup test cases * fixup test cases * replace hardcoded string with enum value in test cases * remove the reference of project_folder * fixup test cases * update help page --------- Co-authored-by: zhiren <zzhan@indocresearch.org> Former-commit-id: 74b12c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In release version 2.10, pilotcli will allow user to upload project folder files using the command below:
pilotcli file upload -p [indoctestproject/projectfolder/Project Folder A]
The way of uploading normal files remains same:
pilotcli file upload -p [indoctestproject/username/files]
But with the latest discussion result, the file upload command will be change to:
Implementation Detail
While listing items, user can use follow command to upload items under shared folder or name folder:
Update help info based on above changes
Outcome
After refactor cli, user can upload items seperately for shared folder and name folder
JIRA Issues
Pilot 4951
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
Updated new test cases