Warhead that can not kill

[FS-21]

• Warheads can now damage the enemy without killing them (minimum health will be 1).
• I tested this tag against conventional weapons and radiation types.

In rulesmd.ini:

[SOMEWARHEAD] ; Warhead
CanKill=true; boolean

[github-actions]

Nightly build for this pull request:

• compiled-dll-ba011225874564e45f20e5f3511c0080105ef062.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Coronia]

idk if setting the target's health to 1 is the correct way, since there's other logic that rely damage greater than 0 to work. Perhaps it would be safer to set the damage to current health - 1.

Also those check warning issues should be fixed as well.

[FS-21]

Since this code was born from a split from another feature I forgot to delete the WH declaration of the posterior if-else :-D thanks!

And I'm against to set -1 since all the games's logic understand positive values but I don't know how are the checks with negative ones. Moreover, probably lots of Phobos checks could break because some checks could be written against health=0 and not negative health (I don't have time for confirming it).

The only reason of the feature is that in case of having a weapon that can potentially kill the object (due to the gamage value and the target's current health) it just leave only 1 point of life, anything else will be able to kill it.

Useful for debuff/plagues, auxiliary logics, etc. This had in mind the PR #1398 and both together fulfills the closed #627

[Metadorius]

And I'm against to set -1 since all the games's logic understand positive values but I don't know how are the checks with negative ones. Moreover, probably lots of Phobos checks could break because some checks could be written against health=0 and not negative health (I don't have time for confirming it).

You misunderstood. @Coronia meant that instead of setting health to 1 it's better to modify the damage before actually applying anything to deal current health - 1 amount of damage, this way it won't be possible for health to go lower than 1.

[FS-21]

You misunderstood. @Coronia meant that instead of setting health to 1 it's better to modify the damage before actually applying anything to deal current health - 1 amount of damage, this way it won't be possible for health to go lower than 1.

I see, sorry I though wrongly it was that different approach when I readed the message :-P
Anyways (unless a skilled one enlight me why I'm thinking wrongly) you can't simply reduce the damage value (integer) until it matches health 1 because the armour (double) calculation not done here and probably other multipliers.
Try to get a value to find the health= 1 if the weapon damage does 125 and it uses a warhead with a 12500% against that target's armour.

Isn't simplier this approach that if the final calculation surpasses the target's health set that minimum health and skip the checks for ending it?

[Otamaa]

You misunderstood. @Coronia meant that instead of setting health to 1 it's better to modify the damage before actually applying anything to deal current health - 1 amount of damage, this way it won't be possible for health to go lower than 1.

I see, sorry I though wrongly it was that different approach when I readed the message :-P Anyways (unless a skilled one enlight me why I'm thinking wrongly) you can't simply reduce the damage value (integer) until it matches health 1 because the armour (double) calculation not done here and probably other multipliers. Try to get a value to find the health= 1 if the weapon damage does 125 and it uses a warhead with a 12500% against that target's armour.

Isn't simplier this approach that if the final calculation surpasses the target's health set that minimum health and skip the checks for ending it?

if you return that early , isnt that mean you will skip some of ares affect then , is it intended behavoiur ?.

[FS-21]

if you return that early , isnt that mean you will skip some of ares affect then , is it intended behavoiur ?.

I changed that behaviour so now it doesn't skip code. I don't see any side effects.

[Coronia]

correct me if I'm wrong, but I think all ReceiveDamage call for techno will go through (0x701900, TechnoClass_ReceiveDamage_Shield) hook, so I'm not sure if a specific handler should be made for rad here. And it might again skip some logic related to receive damage (e.g. shield damage calculation)