Added debug output, optimized performance #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMH-Benny
reviewed
Sep 27, 2024
| $this->$property = $metrics[$property]; | ||
| } | ||
| } | ||
| // Not pretty to set each but more efficient than using a loop and $this->metrics |
There was a problem hiding this comment.
It's not only not so pretty, it also changes the behavior, doesn't it? Perviously it checked if the prop in metrics array exists and if yes set it, so you could have passed deltas to change only like 2 metrics, with your change you always need to put a full set of $metrics, because every not included property will be set to 0.0. That's probably not an issue in this case because this method probably is only called once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.