From 81754215d9393b3b5ec4d9269107d61a145034de Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Thu, 21 Sep 2017 17:14:47 +0200 Subject: [PATCH 1/3] README fixes --- README.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.rst b/README.rst index c946a967..9e96bcad 100644 --- a/README.rst +++ b/README.rst @@ -36,6 +36,7 @@ Features notification support (*optional*) - Modular backup, archiving, upload and notification components - Support for MongoDB Authentication and SSL database connections +- Support for Read Preference Tags for selecting specific nodes for backup - Rotation of backups by time or count - Multi-threaded, single executable - Auto-scales to number of available CPUs by default @@ -80,7 +81,7 @@ To build an CentOS/RedHat RPM of the tool *(recommended)*: :: $ cd /path/to/mongodb_consistent_backup - $ sudo yum install -y rpm-build + $ yum install -y rpm-build $ make rpm To build and install from source *(to default '/usr/local/bin/mongodb-consistent-backup')*: @@ -235,7 +236,9 @@ Roadmap - More testing: this project has many flows that probably need more in-depth testing. Please submit any bugs and/or bugfixes! - "Distributed Mode" for running backup on remote hosts *(vs. only on one host)* +- Binary backup methods *(createBackup/Hot Backup, LVM and EBS snapshots, etc)* - Upload compatibility for ZBackup archive phase *(upload unsupported today)* +- Support Upload with Backup Rotation *(rotated backups are not deleted on upload destination)* - Support more notification methods *(Prometheus, PagerDuty, etc)* - Python unit tests From 5109dd262267f602a88f9cae694f487647747c07 Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Thu, 21 Sep 2017 17:23:12 +0200 Subject: [PATCH 2/3] Remove duplicate line --- README.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/README.rst b/README.rst index b081b697..9e96bcad 100644 --- a/README.rst +++ b/README.rst @@ -35,7 +35,6 @@ Features - `Nagios NSCA `__ push notification support (*optional*) - Modular backup, archiving, upload and notification components -- Rotation of backups by time or count - Support for MongoDB Authentication and SSL database connections - Support for Read Preference Tags for selecting specific nodes for backup - Rotation of backups by time or count From 86b468ed10c409cf334043259fc38ad59607f0ac Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Thu, 21 Sep 2017 17:40:09 +0200 Subject: [PATCH 3/3] Config file typos --- conf/mongodb-consistent-backup.example.conf | 2 +- mongodb_consistent_backup/Oplog/__init__.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/mongodb-consistent-backup.example.conf b/conf/mongodb-consistent-backup.example.conf index d03e69f2..5ecf18a3 100644 --- a/conf/mongodb-consistent-backup.example.conf +++ b/conf/mongodb-consistent-backup.example.conf @@ -18,10 +18,10 @@ production: # mongodump: # binary: [path] (default: /usr/bin/mongodump) # compression: [auto|none|gzip] (default: auto - enable gzip if supported) + # threads: [1-16] (default: auto-generated, shards/cpu) #rotate: # max_backups: [1+] # max_days: [0.1+] - # threads: [1-16] (default: auto-generated, shards/cpu) #replication: # max_lag_secs: [1+] (default: 10) # min_priority: [0-999] (default: 0) diff --git a/mongodb_consistent_backup/Oplog/__init__.py b/mongodb_consistent_backup/Oplog/__init__.py index 18ebfd79..98e81423 100644 --- a/mongodb_consistent_backup/Oplog/__init__.py +++ b/mongodb_consistent_backup/Oplog/__init__.py @@ -6,7 +6,7 @@ def config(parser): parser.add_argument("--oplog.compression", dest="oplog.compression", help="Compression method to use on captured oplog file (default: none)", choices=["none", "gzip"], default="none") - parser.add_argument("--oplog.flush.max_docs", dest="oplog.flush.max_docs", help="Maximum number of oplog document writes to trigger a flush of the backup oplog file (default: 1000)", default=1000, type=int) + parser.add_argument("--oplog.flush.max_docs", dest="oplog.flush.max_docs", help="Maximum number of oplog document writes to trigger a flush of the backup oplog file (default: 100)", default=100, type=int) parser.add_argument("--oplog.flush.max_secs", dest="oplog.flush.max_secs", help="Number of seconds to wait to flush the backup oplog file, if 'max_docs' is not reached (default: 1)", default=1, type=int) parser.add_argument("--oplog.resolver.threads", dest="oplog.resolver.threads", help="Number of threads to use during resolver step (default: 1-per-CPU)", default=0, type=int) parser.add_argument("--oplog.tailer.enabled", dest="oplog.tailer.enabled", help="Enable/disable capturing of cluster-consistent oplogs, required for cluster-wide PITR (default: true)", default='true', type=str)