[Capture][Draft] Promote consts to normal args #7050
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
After seeing how in catalyst that we can promote
constvars
to normal arguments, I realized this could make a lot our higher order primitives much simpler. We would no longer need to slice and dice the consts and args. We could just treat them like the same thing.Description of the Change:
Try promoting the
consts
from the qfunc jaxpr to being normal arguments.Benefits:
Possible Drawbacks:
Related GitHub Issues: