-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Wires
objects as wire labels bug
#6933
base: master
Are you sure you want to change the base?
Conversation
qml.wires.Wires
initializationWires
objects as wire labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6933 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45505 45514 +9
=======================================
+ Hits 45320 45329 +9
Misses 185 185 ☔ View full report in Codecov by Sentry. |
Wires
objects as wire labelsWires
objects as wire labels
Wires
objects as wire labelsWires
objects as wire labels
Wires
objects as wire labelsWires
objects as wire labels bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have in test suite the third example where tuples do not get flattened out ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me! Thanks for fixing this bug!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks flawless to me! 🥇
Only one question, maybe for @isaacdevlugt: since we are changing the wires visualization, should we mark this as a breaking change?
Context:
Prior to this PR we had the following behaviour,
Description of the Change:
Add handling to
_process
that dissolves anyWires
objects that survived to that point. This results in improved behaviour like,Benefits:
Better visualization of wire objects.
Possible Drawbacks: Wire objects will look slightly different.
Related GitHub Issues: Fixes #6669
[sc-79749]