-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] unitary_to_rot
is plxpr
compatible
#6916
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6916 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45520 45547 +27
=======================================
+ Hits 45335 45362 +27
Misses 185 185 ☔ View full report in Codecov by Sentry. |
…ennylane into unitary-to-rot-interpreter
UnitaryToRotInterpreter
for transforming plxpr
unitary_to_rot
is plxpr
compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. I'll do a second pass later to review tests.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much ready to approve. Could you add a test to verify that using @unitary_to_rot
with @qml.capture.expand_plxpr_transforms
works correctly? Check out this PR for a good example
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Context:
This PR adds a
UnitaryToRotInterpreter
to apply theunitary_to_rot
transform natively toplxpr
.Description of the Change:
UnitaryToRotInterpreter
to transformplxpr
Benefits:
unitary_to_rot
can be applied natively to plxpr.Possible Drawbacks: None identified.
[sc-83556]