Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ruff and pylint #78

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Dec 24, 2024

Context:

Prior to this PR, this repository had no support for linting with insufficient GitHub actions. This led to a code-base full of bad practices.

Description of the Change:

A couple of things have been affected

  • Add support for linting packages (ruff and pylint)
  • Clean-up source code and test suite based on these new rules
  • Clean-up dependencies
  • Improve GitHub action (add PR template, improve formatting and linting workflows)

Benefits:

Repository is more organized and employs better coding practices.

Possible Drawbacks: None

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f400595) to head (fdd6bc0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          171       173    +2     
=========================================
+ Hits           171       173    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant