Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORG81 Add automatic formatting/linting github checks #31

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ORG81 Add automatic formatting/linting github checks #31

wants to merge 7 commits into from

Conversation

Alomir
Copy link
Contributor

@Alomir Alomir commented Feb 12, 2025 •
edited
Loading

THIS IS NOT READY FOR REVIEW, BUT NEEDS TO BE MARKED SO IN ORDER TO TEST

@Alomir Alomir marked this pull request as ready for review February 12, 2025 19:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v12.0.0) reports: 1 file(s) not formatted
  • sipnet.c

Have any feedback or feature suggestions? Share it here.

@dlebauer
Copy link
Member

dlebauer commented Feb 18, 2025 •
edited
Loading

🙈 not reviewing but:

  • plz add just a brief instructions on style, and any pre-commit linting that should be done prior to PR to CONTRIBUTING.md. Doesn't need to have details if you can just say 'we are using clang style, as defined in here (some .clang* files) and there (some urls if any).

@Alomir
Copy link
Contributor Author

Alomir commented Feb 18, 2025

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alomir @dlebauer