Fix auto submit on non-form elements #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function to find a related form element. If called on any element it would first try to get a input element and get it's associated form - which can be different and as a last resort to find the element's enclosing form. Otherwise return undefined.
Fix a problem introduces in Patternslib 9.9.7 where pat-autosubmit did not work when not defined on a form or input element. As a side effect, the submit event is now always invoked on the related or nearest form of the element where pat-autosubmit was defined on. If that element is not a form element a related (input.form) or the nearest parent form is searched and the submit event invoked upon.
|
/cc @cornae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where pat-autosubmit is defined on non-form elements, like:
pat-autosubmit invoked a submit event but that never reached the form because that follows not the standard and submit events are meant to be invoked on form elements (or maybe inputs, which did work although I can't derive that behavior from the specs).
See:
https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#submitevent
This use case was broken since Patternslib 9.9.7 where we switched to JavaScript submit events from jQuery submit events to fix another problem.
Now the submit event is always invoked on the related form element. Actually the input element where a change happens can be outside the form itself if it is connected with the form via the
formattribute.