Merge pull request #1222 from Patternslib/pat-inject-modernization

pat-inject code optimizations
Patternslib · Jan 12, 2025 · 13bf6dc · 13bf6dc
2 parents a28a386 + 8a3af53
commit 13bf6dc
Show file tree

Hide file tree

Showing 3 changed files with 182 additions and 138 deletions.
diff --git a/src/core/dom.js b/src/core/dom.js
@@ -60,7 +60,7 @@ const toNodeArray = (nodes) => {
  * @returns {Array} - The DOM nodes found.
  */
 const querySelectorAllAndMe = (el, selector) => {
-    if (!el) {
+    if (!el || !el.querySelectorAll) {
         return [];
     }
 

diff --git a/src/core/dom.test.js b/src/core/dom.test.js
@@ -174,6 +174,15 @@ describe("core.dom tests", () => {
 
             done();
         });
+
+        it("return empty list, if the element is not a real element.", (done) => {
+            const res = dom.querySelectorAllAndMe("text", ".selector");
+            expect(Array.isArray(res)).toBe(true);
+            expect(res.length).toBe(0);
+
+            done();
+        });
+
     });
 
     describe("wrap tests", () => {