Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify freezing with V2 #5

Closed
Patrick-orz opened this issue Feb 5, 2024 · 20 comments
Closed

Spotify freezing with V2 #5

Patrick-orz opened this issue Feb 5, 2024 · 20 comments
Assignees
Labels
bug Something isn't working

Comments

@Patrick-orz
Copy link
Owner

Patrick-orz commented Feb 5, 2024

im using translating to romanji.
in my case , it happen consistently when spotify not on active windows and spotify changing to next song then the issue will produce. already tried 3 / 4 times and it happen consistently

popuplyricsplus

Originally posted by @MetroHospitalsDev in #2 (comment)

@Patrick-orz
Copy link
Owner Author

Patrick-orz commented Feb 5, 2024

I would look into this further tomorrow, is the same issue occurring with other translation targets? (Disabling translations or translating into Chinese for instance)
@MetroHospitalsDev

@Patrick-orz Patrick-orz self-assigned this Feb 5, 2024
@Patrick-orz Patrick-orz added the bug Something isn't working label Feb 5, 2024
@MetroHospitalsDev
Copy link
Contributor

Processor Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz 1.19 GHz
Installed RAM 20.0 GB
Edition Windows 11 Home Single Language Version 22H2
SSD 512GB

Target to other translation :
Google (English) : same like romanji , it make spotify frozen and using 100% CPU and 100% Memory
Chinese : Using 100% CPU and 100% memory , but when the lyrics shows it goes back to normal.
Romaji : Spotify froze , and using 100% CPU and 100 Memory
None Translation : Same like chinese , its using 100% CPU and 100% Memory, but when the lyrics show. goes back to normal
All the trial above happen when spotify not on active window

When spotify on active windows , everything works as intended without using 100% CPU and 100% Memory.

@Patrick-orz
Copy link
Owner Author

I still can't seem to reproduce the issue... Check if my follow setup is correct

5c87a9d725238c7f3c2ebd8971985e94.mp4

I assume this issue isn't prevalent in all versions, can you tell me the latest commit without this issue?

@Patrick-orz
Copy link
Owner Author

BTW, can you show me the output of

$ spicetify config

in the terminal?
I want to see what other extensions or apps are enabled

@MetroHospitalsDev
Copy link
Contributor

Sorry , After tried more attempt.
the issue will reproduce when spotify in minimized state.
but will goes back to normal when the lyrics finished load.

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.02.06-09_15_17.mp4

spicetify

@Patrick-orz
Copy link
Owner Author

Patrick-orz commented Feb 6, 2024

I was able to reproduce the issue :)!

However, I don't think this is a problem on my extension specifically. I tested with the original spicetify popuplyrics plugin, same issue occurs (See below video).

2024-02-05.22-07-56.mp4

The issue is the most apparent when a song has "no lyrics", otherwise RAM & CPU goes up until the lyrics load (as you have described with my plugin as well). The issue is magnified on my modded version probably because of the extended "waiting" time due to the fetching from numerous APIs, causing RAM & CPU to be filled before lyrics actually load.

I would strongly recommend starting an issue on spicetify-cli, explaining this issue fully with reproduction procedures to the original devs (Pin me in the new issue if you start one). I would love if the spicetify team could patch this issue.

Thank you so much for reporting this . Meanwhile, you can try to just leave spotify open (unminized) as a workaround!

This thread would now be closed as the issue is not from the modification rather than the original, and could be mentioned in your new issue within spicetify-cli

@frallatta
Copy link

Hello , im already making the issue @Patrick-orz. spicetify/cli#2807 (comment)

@Patrick-orz
Copy link
Owner Author

Newest version implemented official fix

@Orangy-Man
Copy link

sorry for the necro but ive posted on here before for a different issue but also referenced this. it still happens to be even though i redownloaded the extention

@Patrick-orz
Copy link
Owner Author

sorry for the necro but ive posted on here before for a different issue but also referenced this. it still happens to be even though i redownloaded the extention

@Orangy-Man
Sorry for the late response, I am on break.

The freezing issue does indeed occur, which is weird, since the official extension seems to work smoothly when out of focus, and populyricsplus doesn't diverge from the original too much.

The issue only occurs for me (on mac) when I swipe to a desktop that doesn't contain the running spotify instance hosting the popuplyricsplus window. I assume you are on win from the screenshot you have posted in the different thread, but the environment required for such freezing to occur should be similar nevertheless.

I have a question and a possible workaround which I have mentioned in the previous thread.

  • Does the original popuplyrics extension freeze for you?
  • Potential Workaround If the original popuplyrics extension doesn't freeze : Try enabling popuplyricsplus and original popuplyrics at the same time (illustrated in the image below, left is popuplyricsplus and right is popuplyrics). Run original popuplyrics first then try popuplyricsplus. Although this sounds strange, this method has consistently resolved the issue on my end.
  • If the original popuplyrics extension does freeze, you should probably file an issue in the official spicetify repo first.
Screen Shot 2024-08-10 at 1 03 42 AM

This issue would stay closed unless the problem persists for you. (I should really look into this weird freezing issue more in depth...)

@Patrick-orz Patrick-orz pinned this issue Aug 11, 2024
@Orangy-Man
Copy link

sorry for the extreamly late response, im not really paying attention to github since i dont use it much. Ive recoreded a little video of this glitch happening while im playing a game, im not 100% sure if this happens in any other of my games but since i was in minecraft at the time ill just use that as a base. this time, i only have popuplyrics plus. i was also playing on an online server if that adds anything

spicetify.extention.glitch.mov

@Patrick-orz
Copy link
Owner Author

I don't think this has anything to do with minecraft specifically, it's probably the fullscreen nature of the game. The video doesn't really help though, can you answer the questions in my previous post and try the proposed solutions?

sorry for the necro but ive posted on here before for a different issue but also referenced this. it still happens to be even though i redownloaded the extention

@Orangy-Man Sorry for the late response, I am on break.

The freezing issue does indeed occur, which is weird, since the official extension seems to work smoothly when out of focus, and populyricsplus doesn't diverge from the original too much.

The issue only occurs for me (on mac) when I swipe to a desktop that doesn't contain the running spotify instance hosting the popuplyricsplus window. I assume you are on win from the screenshot you have posted in the different thread, but the environment required for such freezing to occur should be similar nevertheless.

I have a question and a possible workaround which I have mentioned in the previous thread.

  • Does the original popuplyrics extension freeze for you?
  • Potential Workaround If the original popuplyrics extension doesn't freeze : Try enabling popuplyricsplus and original popuplyrics at the same time (illustrated in the image below, left is popuplyricsplus and right is popuplyrics). Run original popuplyrics first then try popuplyricsplus. Although this sounds strange, this method has consistently resolved the issue on my end.
  • If the original popuplyrics extension does freeze, you should probably file an issue in the official spicetify repo first.
Screen Shot 2024-08-10 at 1 03 42 AM This issue would stay closed unless the problem persists for you. _(I should really look into this weird freezing issue more in depth...)_

@Orangy-Man
Copy link

I don't think this has anything to do with minecraft specifically, it's probably the fullscreen nature of the game. The video doesn't really help though, can you answer the questions in my previous post and try the proposed solutions?

sorry for the necro but ive posted on here before for a different issue but also referenced this. it still happens to be even though i redownloaded the extention

@Orangy-Man Sorry for the late response, I am on break.
The freezing issue does indeed occur, which is weird, since the official extension seems to work smoothly when out of focus, and populyricsplus doesn't diverge from the original too much.
The issue only occurs for me (on mac) when I swipe to a desktop that doesn't contain the running spotify instance hosting the popuplyricsplus window. I assume you are on win from the screenshot you have posted in the different thread, but the environment required for such freezing to occur should be similar nevertheless.
I have a question and a possible workaround which I have mentioned in the previous thread.

  • Does the original popuplyrics extension freeze for you?
  • Potential Workaround If the original popuplyrics extension doesn't freeze : Try enabling popuplyricsplus and original popuplyrics at the same time (illustrated in the image below, left is popuplyricsplus and right is popuplyrics). Run original popuplyrics first then try popuplyricsplus. Although this sounds strange, this method has consistently resolved the issue on my end.
  • If the original popuplyrics extension does freeze, you should probably file an issue in the official spicetify repo first.
Screen Shot 2024-08-10 at 1 03 42 AM This issue would stay closed unless the problem persists for you. _(I should really look into this weird freezing issue more in depth...)_

iirc, the orignal one also froze and thats why i looked for an alternative in the first place. and for the workaround, i will test that now and then get back to you

@Orangy-Man
Copy link

also

I don't think this has anything to do with minecraft specifically, it's probably the fullscreen nature of the game. The video doesn't really help though, can you answer the questions in my previous post and try the proposed solutions?

i have a mod that adds borderless windowed mode so im not sure that would be the issue. it works sometimes but not all the time

@Orangy-Man
Copy link

ok i just got done testing both. At least today, they both scroll but the scrolling is very slow.

@Patrick-orz
Copy link
Owner Author

If the original doesn't scroll, please submit an issue to the original spicetify repo as I have mentioned.

ok i just got done testing both. At least today, they both scroll but the scrolling is very slow.

I assume the freezing issue doesn't appear from the phrase "they both scroll". I don't understand what you mean by "the scrolling is very slow" though. Please elaborate.

@Orangy-Man
Copy link

If the original doesn't scroll, please submit an issue to the original spicetify repo as I have mentioned.

ok i just got done testing both. At least today, they both scroll but the scrolling is very slow.

I assume the freezing issue doesn't appear from the phrase "they both scroll". I don't understand what you mean by "the scrolling is very slow" though. Please elaborate.

by "scroll slowly" i meant that they are buffering a lot, like its having trouble with something

@Patrick-orz
Copy link
Owner Author

That is still a vague description, please send a video to illustrate (include the behavior of both original PopupLyrics and PopupLyricsPlus).

@Orangy-Man
Copy link

That is still a vague description, please send a video to illustrate (include the behavior of both original PopupLyrics and PopupLyricsPlus).

on the off chance i do get the lyrics to scroll, this is what i meant by it going slowly

Buffering.mov

@Patrick-orz
Copy link
Owner Author

I see no issue in the video, it is the expected behaviour for both PopupLyrics and PopupLyricsPlus (the lyrics scroll in sync with the song playing).

If both PopupLyrics and PopupLyricsPlus freeze from time to time, I again suggest reporting the issue in the official spicetify repo first in order to have PopupLyrics functioning correctly for you first.

If only PopupLyricsPlus dysfunctions, even with my proposed workaround, I will try to pinpoint the core of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants