Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in a participant's state/feature leads to disconnected pathway in biopax/sbgn #28

Closed
jvwong opened this issue Jun 27, 2022 · 7 comments
Labels
question Further information is requested

Comments

@jvwong
Copy link
Member

jvwong commented Jun 27, 2022

In examining several SBGN versions of pathways derived from Biofactoid, have noticed when a state-change is involved, it leads to a 'disjoint' or break in the set of interactions. Clearly, this is because assigning state (even explicitly assigning the absence of a feature/modification) creates distinct pools of the entity. At best it looks odd to have a single binary network (in biofactoid/SIF) look like multiple disjoint interaction sets (e.g. in PC/SBGN).

Illustrate this with an example for Waters et al. Cell Rep (2021):
Screen Shot 2022-06-27 at 5 47 02 PM

The corresponding BioPAX/SBGN version(viewed in pc apps)

pcapps_Targetingp130Cas

Note that BCAR1 above is the official symbol for p130Cas (in biofactoid).


While this seems technically correct, it appears strange to take each interaction 'out of context' from other interactions. I wonder if there is a better way to handle this type of conversion.

@jvwong jvwong added the question Further information is requested label Jun 27, 2022
@gbader
Copy link
Member

gbader commented Jun 27, 2022 via email

@jvwong
Copy link
Member Author

jvwong commented Jun 28, 2022

A reaction/interaction would be needed to link these entities.

I can post more examples below.


For the above example, it occurs to me that the author intended to say that "Phosphorylated form of p130Cas (BCAR1-p) activates DOCK1" so perhaps there's indeed something lost in the translation.

@jvwong
Copy link
Member Author

jvwong commented Jun 28, 2022

Example with modifications splitting a pathway in 3 chunks Zheng et al. Theranostics (2019):

Biofactoid doc:
biofactoid

BioPAX/SBGN

SBGN

@jvwong
Copy link
Member Author

jvwong commented Jun 28, 2022

Example with seemingly duplicate entity (UBE2A) Cell Rep 31 2020:

Biofactoid:

factoid

BioPAX/SBGN:

SBGN

@gbader
Copy link
Member

gbader commented Jun 29, 2022 via email

@jvwong
Copy link
Member Author

jvwong commented Jun 29, 2022

I linked it above and in #30

@jvwong
Copy link
Member Author

jvwong commented Oct 4, 2022

I think there's two separate issues in the previous discussion worth distinguishing:

  1. Participant is assigned some state and is inferred from the Biofactoid based on the type of interaction. For instance, a modification in Biofactoid translates to a BioPAX control/conversion where the controlled participant gets some state via the converter. This, in fact, is by design, and was discussed in the "Factoid binary interaction types" Google Doc.

e.g. #28 (comment)

  1. Duplicate. This seems to be a bug.

e.g. #30

@jvwong jvwong closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants