Added links to databases to pathway view title #1023
Conversation
|
Just curious where did you get the URLs for the databases? |
|
Googled it for most of them. If I couldn't find a direct link, the link is to the journal article for the database (ex: pid goes to https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2686461/) |
|
OK, I'm fine with the decision for those with no live URL. |
|
Update: Turns out this doesn't actually fix #930 |
|
How about using |
|
Also, maybe we can make all links consistent and use the plain link style that the tooltips and the protein info box uses |
|
Something like this?
|
|
Yes, but I think Dylan meant just the blue underline on links. |
|
There should be a |
| @@ -84,9 +86,32 @@ class Pathways extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| baseNameToUrl(baseName){ | |||
There was a problem hiding this comment.
I think this function belongs in datasource-url-map
| const baseDatasource = pathway.datasource(); | ||
| const databaseURL = this.baseNameToUrl(baseDatasource); | ||
| let baseName = pathway.name(); | ||
| if(baseName.toLowerCase() === 'unknown title'){ |
There was a problem hiding this comment.
Maybe you can just change the default value returned by pathway.name(). What do you think?
There was a problem hiding this comment.
I can't figure out where pathway.name() is being defined, do you know?
There was a problem hiding this comment.
|
@jvwong thoughts on this? |
|
Works for me! |
|
Thoughts on the way that the name and title are displayed? |
|
Actually, just a sec: Those database names aren't going to work: e.g. pid |
|
'pid' is the only one - probably should be displayed as 'NCI-PID' |
|
I think the names are based on metadata for the network: I could add in a quick fix and directly change 'pid' to 'NCI-PID', but that seems like bad practice. Any ideas? |
|
OK then - I am fine with all of this. Notes for future: Datasource derived from traversal into pathway object. Should be improved with mapping file |
|
Hi - just noticed the move of the database name to be first. Users don't care about the database name - they want to see the pathway name first. Database groups, I'm sure, would like to see their name first, but they are secondary to users. Did you guys discuss that? |
|
I think the initial proposal is in this issue, but I don't think we had any discussion about it. |
|
Ok - we just need to add the links. The original title format and order was fine. |
|
That was my suggestion to put the |
Fixes #1018
Fixes #930
Reversed the order of
Pathway name | Datasource=>Datasource | Pathway name.Removed "Unknown Title" text if it were to appear.
The map should be correct for all datasources as of right now, but there is also a string similarity calculation included as backup in case the names change in future.