diff --git a/src/ServiceControl.Audit.AcceptanceTests/TestSupport/ServiceControlComponentRunner.cs b/src/ServiceControl.Audit.AcceptanceTests/TestSupport/ServiceControlComponentRunner.cs index ba6f54ad66..0866b504db 100644 --- a/src/ServiceControl.Audit.AcceptanceTests/TestSupport/ServiceControlComponentRunner.cs +++ b/src/ServiceControl.Audit.AcceptanceTests/TestSupport/ServiceControlComponentRunner.cs @@ -51,7 +51,6 @@ async Task InitializeServiceControl(ScenarioContext context) TransportConnectionString = transportToUse.ConnectionString, MaximumConcurrencyLevel = 2, ServiceControlQueueAddress = "SHOULDNOTBEUSED", - OtelMetricsUrl = "http://localhost:4317", MessageFilter = messageContext => { var id = messageContext.NativeMessageId; diff --git a/src/ServiceControl.Audit/Auditing/AuditIngestion.cs b/src/ServiceControl.Audit/Auditing/AuditIngestion.cs index 3c5b47a288..93f93ca665 100644 --- a/src/ServiceControl.Audit/Auditing/AuditIngestion.cs +++ b/src/ServiceControl.Audit/Auditing/AuditIngestion.cs @@ -95,6 +95,7 @@ async Task EnsureStarted(CancellationToken cancellationToken = default) await stoppable.StopReceive(cancellationToken); logger.Info("Shutting down due to failed persistence health check. Infrastructure shut down completed"); } + return; } @@ -161,6 +162,7 @@ async Task EnsureStopped(CancellationToken cancellationToken = default) logger.Info("Shutting down. Already stopped, skipping shut down"); return; //Already stopped } + var stoppable = queueIngestor; queueIngestor = null; logger.Info("Shutting down. Infrastructure shut down commencing"); @@ -255,7 +257,7 @@ async Task Loop() readonly Settings settings; readonly Channel channel; readonly Histogram batchSizeMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.batch_size"); - readonly Histogram batchDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.batch_duration_ms"); + readonly Histogram batchDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.batch_duration", unit: "ms"); readonly Counter receivedMeter = AuditMetrics.Meter.CreateCounter($"{AuditMetrics.Prefix}.received"); readonly Watchdog watchdog; readonly Task ingestionWorker; diff --git a/src/ServiceControl.Audit/Auditing/AuditPersister.cs b/src/ServiceControl.Audit/Auditing/AuditPersister.cs index 16eae2f401..1afceeab00 100644 --- a/src/ServiceControl.Audit/Auditing/AuditPersister.cs +++ b/src/ServiceControl.Audit/Auditing/AuditPersister.cs @@ -283,11 +283,11 @@ await messageDispatcher.Value.Dispatch(new TransportOperations(messagesToEmit.To } } - readonly Counter ingestedAuditMeter = AuditMetrics.Meter.CreateCounter($"{AuditMetrics.Prefix}.ingested_audit_messages"); // metrics.GetCounter("Audit ingestion - ingested audit"); - readonly Counter ingestedSagaAuditMeter = AuditMetrics.Meter.CreateCounter($"{AuditMetrics.Prefix}.ingested_saga_audits"); // metrics.GetCounter("Audit ingestion - ingested audit"); - readonly Histogram auditBulkInsertDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.audit_bulk_insert_duration_ms"); // metrics.GetCounter("Audit ingestion - ingested audit"); - readonly Histogram sagaAuditBulkInsertDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.saga_bulk_insert_duration_ms"); // metrics.GetCounter("Audit ingestion - ingested audit"); - readonly Histogram bulkInsertCommitDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.audit_commit_duration_ms"); // metrics.GetCounter("Audit ingestion - ingested audit"); + readonly Counter ingestedAuditMeter = AuditMetrics.Meter.CreateCounter($"{AuditMetrics.Prefix}.stored_audit_messages"); + readonly Counter ingestedSagaAuditMeter = AuditMetrics.Meter.CreateCounter($"{AuditMetrics.Prefix}.stored_saga_audits"); + readonly Histogram auditBulkInsertDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.bulk_insert_duration_audit", unit: "ms"); + readonly Histogram sagaAuditBulkInsertDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.bulk_insert_duration_sagas", unit: "ms"); + readonly Histogram bulkInsertCommitDurationMeter = AuditMetrics.Meter.CreateHistogram($"{AuditMetrics.Prefix}.commit_duration_audit", unit: "ms"); static readonly ILog Logger = LogManager.GetLogger(); } diff --git a/src/ServiceControl.Audit/Auditing/AuditMetrics.cs b/src/ServiceControl.Audit/Infrastructure/AuditMetrics.cs similarity index 55% rename from src/ServiceControl.Audit/Auditing/AuditMetrics.cs rename to src/ServiceControl.Audit/Infrastructure/AuditMetrics.cs index 3e02448fa1..25a9fa658f 100644 --- a/src/ServiceControl.Audit/Auditing/AuditMetrics.cs +++ b/src/ServiceControl.Audit/Infrastructure/AuditMetrics.cs @@ -1,9 +1,9 @@ -namespace ServiceControl.Audit.Auditing; +namespace ServiceControl.Audit; using System.Diagnostics.Metrics; static class AuditMetrics { - public static readonly Meter Meter = new("ServiceControl", "0.1.0"); + public static readonly Meter Meter = new("Particular.ServiceControl", "0.1.0"); public static readonly string Prefix = "particular.servicecontrol.audit"; } \ No newline at end of file