Global suppressions should be expressed in .editorconfig files so they are easily findable: > src/ServiceControl.Transports.Tests/GlobalSuppressions.cs

Workflows should set the default shell to 'pwsh' or 'bash' ensure same functionality on all platforms, unless there are no run steps: > .github/workflows/build-windows.yml - Job 'build' does not have a default shell defined at the workflow or job level. > .github/workflows/ci.yml - Job 'build' does not have a default shell defined at the workflow or job level.

InternalsVisibleTo should be registered in project files: > src/ServiceControl.Config/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Config.Tests" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.UnitTests" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTests" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTests.RavenDB" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTesting" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.PersistenceTests" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Persistence.Tests.RavenDB" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.MultiInstance.AcceptanceTests" />' > src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Persistence.RavenDb" />' > src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests" />' > src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.UnitTests" />' > src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.Persistence.Tests" />' > src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.Persistence.Tests.RavenDB" />' > src/ServiceControlInstaller.Engine/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControlInstaller.Engine.UnitTests" />' > src/ServiceControlInstaller.Engine/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Config.Tests" />' > src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.UnitTests" />' > src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.PersistenceTests" />' > src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Persistence.Tests.RavenDB" />' > src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTests.RavenDB" />' > src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.MultiInstance.AcceptanceTests" />' > src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.UnitTests" />' > src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests" />' > src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests.RavenDB" />' > sr