Adding healthcheck command to docker #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
changed the title
PhilBastian
approved these changes
Feb 4, 2025
Comment on lines
+31
to
+32
|
|
||
|
|
|
|
||
| var hostSettings = new HostSettings( | ||
| configuration.ReturnQueue, | ||
| $"Queue creator for {configuration.ReturnQueue}", |
There was a problem hiding this comment.
without looking at the signature... should this be a different description?
There was a problem hiding this comment.
I don't think this matters
| return (false, e.Message); | ||
| } | ||
|
|
||
| return (true, string.Empty); |
There was a problem hiding this comment.
so if it fails for any reason other than brokerunreachable it will still be marked as healthy? This is the description of the healthchecker... but seems to me like it could cause some confusion
There was a problem hiding this comment.
so if it fails for any reason other than brokerunreachable it will still be marked as healthy?
no, it will be an unhandled exception and therefore it will be exit code 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
health-checkcommand to the CLI, and then we use it to check if the container is healthy.