Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralize validValueOrId check #19

Open
mathdroid opened this issue Feb 13, 2024 · 4 comments
Open

centralize validValueOrId check #19

mathdroid opened this issue Feb 13, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mathdroid
Copy link
Collaborator

          just an idea, not needed for this version: this logic could be a function since we reuse it everywhere, it's critical, and when we want to support burning it will need to be changed in many places.

Originally posted by @caldereth in #17 (comment)

@mathdroid mathdroid added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@aruns05
Copy link

aruns05 commented Feb 24, 2024

@mathdroid is this being worked upon ?

@mathdroid
Copy link
Collaborator Author

it should already be in the current impl. closing after confirmation @0xacme @caldereth

@gaavar
Copy link

gaavar commented Feb 24, 2024

I think that the _isValidTokenId implements this and is present in the main branch.

@aruns05
Copy link

aruns05 commented Feb 24, 2024

Is there any other good first issue,interested in contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants