Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest for custom avatar #2246

Closed
wants to merge 4 commits into from

Conversation

nidhin29
Copy link

This change included the Unittest for custom avatar

Issue Number: #1127

Fixed #1127

Did you add tests for your changes?

Yes

Summary

It is unittest for custom avatar.

Does this PR introduce a breaking change?

No, this does not introduce any major changes to the codebase.

Have you read the contributing guide?

Yes, i have followed the guidelines.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (405f49d) 80.41% compared to head (a20e52c) 80.41%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2246   +/-   ##
========================================
  Coverage    80.41%   80.41%           
========================================
  Files          149      149           
  Lines         7006     7006           
========================================
  Hits          5634     5634           
  Misses        1372     1372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nidhin29 nidhin29 closed this Dec 14, 2023
@palisadoes
Copy link
Contributor

Please watch this video. We mention closed PRs near the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittests for widget custom_avatar.dart
2 participants