Revert "Navigation Services Test Written" #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 23c2a74.
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2234 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 149 149
Lines 6986 6986
========================================
Hits 5599 5599
Misses 1387 1387 ☔ View full report in Codecov by Sentry. |
palisadoes
added a commit
that referenced
this pull request
Dec 17, 2023
* fetchmore bug fix in organizationlist widget * fetchmore result typecast * Refactor talawa conneciton url to hamburger menu * minor changes * minor fixes * minor fixes * minor fixes * added comments to the files mentioned in the failing test case. * added comments * minor fixes * ran build runner * fixed fail test * Bug fix: Edited tag does not get updated immediately (#2224) * Fixing bug to join or switch to any joined org (#2216) * Fixing bug to join or switch to any joined org * fixing linting errors * fixing * fixing coverage * fixing overflow error * fixing overflow error * Fixes Snackbar clipping by adding an auto scroll and duration based on length of message (#2231) * fix: Snackbar clipping by adding an auto scroll based on length of message * changes to tests and added documentation * minor changes to documentation * Navigation Services Test Written (#2230) * Navigation Services Test Written * Null Check Error Fixed * Update pull_request_template.md * Revert "Navigation Services Test Written (#2230)" (#2234) This reverts commit 23c2a74. * Refactor talawa conneciton url to hamburger menu * Bug fix: Edited tag does not get updated immediately (#2224) * Refactor talawa conneciton url to hamburger menu * Bug fix: Edited tag does not get updated immediately (#2224) * add some tests * added some tests * added tests to userConfig Service * fixed failing tests * fixed failing tests * added tests for explore_events_demo page * added comments for event_card widget * made add_post_page 100% code covered. * Refactor talawa conneciton url to hamburger menu * Navigation Services Test Written (#2230) * Navigation Services Test Written * Null Check Error Fixed * add tests to mainscreenviewModel * resolve conflicts * fixed failing test * added tests to apptour file --------- Co-authored-by: Bhav Khurana <96694482+bhav-khurana@users.noreply.github.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: Hemanth Krishnakumar <72601105+Wreck-X@users.noreply.github.com> Co-authored-by: Manik Mehta <mehtamanik96@gmail.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com>
palisadoes
added a commit
to palisadoes/talawa
that referenced
this pull request
Jan 10, 2024
palisadoes
added a commit
to palisadoes/talawa
that referenced
this pull request
Jan 10, 2024
* fetchmore bug fix in organizationlist widget * fetchmore result typecast * Refactor talawa conneciton url to hamburger menu * minor changes * minor fixes * minor fixes * minor fixes * added comments to the files mentioned in the failing test case. * added comments * minor fixes * ran build runner * fixed fail test * Bug fix: Edited tag does not get updated immediately (PalisadoesFoundation#2224) * Fixing bug to join or switch to any joined org (PalisadoesFoundation#2216) * Fixing bug to join or switch to any joined org * fixing linting errors * fixing * fixing coverage * fixing overflow error * fixing overflow error * Fixes Snackbar clipping by adding an auto scroll and duration based on length of message (PalisadoesFoundation#2231) * fix: Snackbar clipping by adding an auto scroll based on length of message * changes to tests and added documentation * minor changes to documentation * Navigation Services Test Written (PalisadoesFoundation#2230) * Navigation Services Test Written * Null Check Error Fixed * Update pull_request_template.md * Revert "Navigation Services Test Written (PalisadoesFoundation#2230)" (PalisadoesFoundation#2234) This reverts commit 23c2a74. * Refactor talawa conneciton url to hamburger menu * Bug fix: Edited tag does not get updated immediately (PalisadoesFoundation#2224) * Refactor talawa conneciton url to hamburger menu * Bug fix: Edited tag does not get updated immediately (PalisadoesFoundation#2224) * add some tests * added some tests * added tests to userConfig Service * fixed failing tests * fixed failing tests * added tests for explore_events_demo page * added comments for event_card widget * made add_post_page 100% code covered. * Refactor talawa conneciton url to hamburger menu * Navigation Services Test Written (PalisadoesFoundation#2230) * Navigation Services Test Written * Null Check Error Fixed * add tests to mainscreenviewModel * resolve conflicts * fixed failing test * added tests to apptour file --------- Co-authored-by: Bhav Khurana <96694482+bhav-khurana@users.noreply.github.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: Hemanth Krishnakumar <72601105+Wreck-X@users.noreply.github.com> Co-authored-by: Manik Mehta <mehtamanik96@gmail.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2230
We have to revert this PR. It's causing others to fail. Here is a specific error caused by files modified in the original #2230 PR