Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Setup Script Creates the Wrong API URL #3493

Closed
palisadoes opened this issue Jan 31, 2025 · 6 comments
Closed

NoMongo: Setup Script Creates the Wrong API URL #3493

palisadoes opened this issue Jan 31, 2025 · 6 comments
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers unapproved

Comments

@palisadoes
Copy link
Contributor

Describe the bug

We are migrating to the new develop-postgres branch. There are bugs in the initial login screen being addressed here:
- #3477

However there is another issue preventing others from accessing the portal correctly

  1. The setup script creates .env files with the REACT_APP_TALAWA_URL parameter having a trailing /. It must be removed for the latest API1. Instead of this
REACT_APP_TALAWA_URL=http://localhost:4000/graphql/
  1. It should create this
REACT_APP_TALAWA_URL=http://localhost:4000/graphql
  1. In stead of a 404 message, there should be an invalid data message

To Reproduce
Steps to reproduce the behavior:

  1. Use the setup script
  2. Start Talawa-admin
  3. Access the Talawa-Admin URL
  4. The wrong error is shown

Expected behavior
A clear and concise description of what you expected to happen.

Actual behavior
A clear and concise description of how the code performed w.r.t expectations.

Screenshots

  1. When configured correctly, when using Talawa-Admin by accessing this URL
http://localhost:4321
  1. The initial error message must be
    Image
  2. Not this
    Image

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 31, 2025
@github-actions github-actions bot added feature request invalid This doesn't seem right ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 31, 2025
@palisadoes palisadoes removed invalid This doesn't seem right ui/ux issue related and being worked with the figma file of the Admin UI labels Jan 31, 2025
@JaiPannu-IITI
Copy link

@palisadoes Can i work on this?

@LakshayPuhal
Copy link

@palisadoes i would like to contribute here.

@vivekbisen04
Copy link

@palisadoesI would like to work on this issue. Please assign it to me.

@rishyym0927
Copy link

@palisadoes I’d love to take up the issue regarding the REACT_APP_TALAWA_URL parameter in the setup script while migrating to the develop-postgres branch. Specifically, I'll:

✅ Update the setup script to remove the trailing / in REACT_APP_TALAWA_URL
✅ Ensure the correct error message is displayed instead of a 404
✅ Verify that Talawa-Admin behaves as expected after the fix

Can this issue be assigned to me? Looking forward to contributing! 😊

@JaiPannu-IITI
Copy link

Thank you for assigning this to me. I am starting work on it now.

@JaiPannu-IITI
Copy link

@palisadoes This issue required modifying a sensitive file. Could you please review the changes and add the ignore-sensitive-file label to this PR? Thanks!

@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-Admin Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers unapproved
Projects
Status: Done
Status: Done
Development

No branches or pull requests

5 participants