Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Validate and Fix Organization related Mutations and Query against the `develop-postgres' branch #3487

Closed
hustlernik opened this issue Jan 30, 2025 · 36 comments
Assignees

Comments

@hustlernik
Copy link
Contributor

hustlernik commented Jan 30, 2025

Is your feature request related to a problem? Please describe.
Update Mutations and Queries related to Organization according to develop-postgres branch.
Not able to fetch Organization in User Portal.

Describe the solution you'd like

Update all the Graphql queries and mutation to match new API structure in organization.tsx , orglist.tsx and organizationDashboard.tsx, modify and improve code coverage accordingly.

1.Update GraphQL query to retrieve organizations created by a user.
2.Update GraphQL query to retrieve organizations joined by a user.
3.Update GraphQL query to retrieve organizations based on user connection.
4.Update GraphQL query to take the Organization with data

In order to solve these issues smoothy,
#3296
#3198

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@hustlernik
Copy link
Contributor Author

@palisadoes please assign me

@hustlernik
Copy link
Contributor Author

Though I am assigned with 2 issues currently but to solve them I need to fix this first.

@palisadoes
Copy link
Contributor

You haven't explained in the issue what you are planning on doing and why

@hustlernik
Copy link
Contributor Author

For Example, we need to modify the queries and mutations to adhere to new api structure.

Image

Image

Image

@hustlernik
Copy link
Contributor Author

In new user type there is no field like appUserProfile or joinedOrganization, many more examples that need to be adapted.

@palisadoes
Copy link
Contributor

OK

@hustlernik
Copy link
Contributor Author

hustlernik commented Jan 31, 2025

@palisadoes In MutationCreateOrganizationInput, we have countryCode rather than country, which we had previously, so there will be a change in organizationModal, will we have dropdown to select countryCode or just field? I guess dropdown.

Image

@palisadoes
Copy link
Contributor

There will need to be a country code to country lookup for each supported language in the clients. Dropdowns for example.

@palisadoes
Copy link
Contributor

Why do you need administrators fetched in the queue?

@hustlernik
Copy link
Contributor Author

Why do you need administrators fetched in the queue?

Pardon

@palisadoes
Copy link
Contributor

Open a separate issue afterward to fix the country code translation. We need this fixed quickly.

@hustlernik
Copy link
Contributor Author

Okay.

@palisadoes
Copy link
Contributor

In both queries above, you have included admin ID information

@palisadoes
Copy link
Contributor

I see, they are new and old queries

@hustlernik
Copy link
Contributor Author

@palisadoes Progress till now, now admin can create new organization.

Screen.Recording.2025-01-31.185032_resized.mp4
Screen.Recording.2025-01-31.185318.mp4

@hustlernik
Copy link
Contributor Author

hustlernik commented Jan 31, 2025

I will raise the first PR for this issue after this #3477 gets merged.

@hustlernik
Copy link
Contributor Author

Now fixing when admin creates new org, after creating it should be visible.

Image

@hustlernik
Copy link
Contributor Author

@palisadoes

Screen.Recording.2025-01-31.195125_resized.mp4

@palisadoes
Copy link
Contributor

Ask @rahulch07 to collaborate on a joint PR so that there is no delay

@rahulch07
Copy link
Contributor

@hustlernik are you done refactoring this component?

Image

@palisadoes
Copy link
Contributor

@hustlernik Please submit a PR. Work in the repositories is stagnant because this issue hasn't been resolved

@hustlernik
Copy link
Contributor Author

@palisadoes Just doing it.

@hustlernik
Copy link
Contributor Author

@palisadoes I have raised first PR for this issue where admin can create organization and have membership to it. Changed Organization Creation modal according to API structure and written test for it.

@hustlernik
Copy link
Contributor Author

@hustlernik are you done refactoring this component?

Image

I am doing it, will be done in some time.

@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-Admin Feb 1, 2025
@hustlernik
Copy link
Contributor Author

@palisadoes Please do not close this issue, it is not complete.

@palisadoes palisadoes reopened this Feb 1, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in NoMongo: Talawa-Admin Feb 1, 2025
@hustlernik
Copy link
Contributor Author

@palisadoes I am working on organizationDashboard.tsx

@palisadoes
Copy link
Contributor

  1. When would you be able to submit a PR?
  2. Development has come to a standstill

@rahulch07
Copy link
Contributor

@hustlernik do you need any help with your PR?

@hustlernik
Copy link
Contributor Author

  1. When would you be able to submit a PR?
  2. Development has come to a standstill

I am continuously working on it @palisadoes, Please give some time, I will raise a PR as soon as possible.

@hustlernik
Copy link
Contributor Author

@hustlernik do you need any help with your PR?

I will let you know, thanks.

@gkbishnoi07
Copy link

@hustlernik, @palisadoes will the "Manage" button be functional now? It's been non-functional so far, which is why I raised an issue. The problem seems to be in the OrgListCard—the button wasn't being triggered. After fixing the button itself, it gets triggered, but the issue persists in the API, as it's not fetching the data. I think this might have been addressed in your PR. Should I raise a separate PR for the triggered button, or will it be resolved within your PR?

@hustlernik
Copy link
Contributor Author

@gkbishnoi07 This is fixed and I will raise the PR for the same ASAP, I am working on further fixes.

@hustlernik
Copy link
Contributor Author

hustlernik commented Feb 3, 2025

@palisadoes

Do we have block User functionality handled at backend, I have seen the graphQL docs but not able to find it, same for Membership Request and Volunteer Ranking?

@palisadoes
Copy link
Contributor

palisadoes commented Feb 4, 2025

The aim was to give the option to:

  1. deny membership requests from users.
  2. block the user from making posts if an administrator ruled that they were against the rules

I don't know about Volunteer Ranking.

I'm not sure whether the features were implemented, but they will eventually need to be. It would be a useful feature to add, possibly in a GSoC idea.

@hustlernik
Copy link
Contributor Author

@palisadoes Okay, let's have all the migration completed. If we get time, I will try to complete these features myself before GSOC, why to wait?

@palisadoes
Copy link
Contributor

Sure. Do it before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants