Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Code Coverage GitHub Action Test for Values > 0% #3348

Open
palisadoes opened this issue Jan 18, 2025 · 10 comments
Open

Fix Code Coverage GitHub Action Test for Values > 0% #3348

palisadoes opened this issue Jan 18, 2025 · 10 comments
Assignees
Labels
bug Something isn't working feature request test Testing application unapproved

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. We are migrating from jest to vitest for our test suite
  2. We had to modify our GitHub Actions workflow to calculate the total code coverage from both suites (See screenshots below)
  3. The Very Good Coverage check now fails for any value set > 0
    1. https://github.com/VeryGoodOpenSource/very_good_coverage
  4. We need to be able to set this value to the 90% overall code coverage for the repo.
  5. Checks need to fail if either the PR code patch or the overall repo's code coverage falls below this threshold
  6. The GitHub action file can be found here:
    1. https://github.com/PalisadoesFoundation/talawa-admin/blob/develop-postgres/.github/workflows/pull-request.yml

To Reproduce
Here is an example of a failing test suite when the threshold value was set to 89%

Image

Expected behavior

  • See above

Actual behavior

  • See above

Screenshots

  1. Merging of the code coverage files from jest and vitest
    Image

  2. The failing check section. Failures only happen when not set to zero
    Image

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes
Copy link
Contributor Author

@varshith257

@varshith257
Copy link
Member

varshith257 commented Jan 19, 2025

I am thinking once all jest files are converted to vitest, we can re-enable it by remove those all flags introduced

Let's put priority on that refactor issues and Prs and close them ASAP

@palisadoes
Copy link
Contributor Author

I'll assign it to you so we don't forget

How far away are we from completing the vitest conversion?

@varshith257
Copy link
Member

I think only 3-4 issues left

@palisadoes
Copy link
Contributor Author

You should take them over and complete them if there is no response.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 29, 2025
@palisadoes
Copy link
Contributor Author

Pull-request.yml has statements related to the simultaneous user of jest and vitest. These will need to be removed

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 29, 2025
@palisadoes
Copy link
Contributor Author

@varshith257

  1. This is the current test code coverage on develop-postgres. It should be > 95%
  2. Can you fix this?

Image

@varshith257
Copy link
Member

I will look into this

@palisadoes
Copy link
Contributor Author

@varshith257 Have you managed to make any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request test Testing application unapproved
Projects
Status: Backlog
Development

No branches or pull requests

2 participants