Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296

Open
palisadoes opened this issue Jan 16, 2025 · 16 comments
Open

NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296

palisadoes opened this issue Jan 16, 2025 · 16 comments
Assignees
Labels
feature request GSoC Priority ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

A simple "search and replace" is not enough. Please read carefully

Is your feature request related to a problem? Please describe.

  1. We will eventually implement a Light / Dark Mode option in the Web UI
  2. To make this easier we need to review the single CSS style sheet to remove references to colors and replace them with the role of the color in components or screens. For example:
    1. Instead of --red-delete-bg use --delete-button-bg
    2. Instead of --red-delete-text use --delete-button-text
    3. Instead of --blue-primary use a name that describes the role of the color like --margin-color-for-xxxxxxxx where xxxxxxx is the component
  3. This will mean that you'll have to go through all the use cases for each color and add additional variables with the same or different colors according to the role. For example:
    1. References to --brown-color occur 25 times in different roles in different screens and components.
    2. References to --light-dark-green occur 3 times in similar situations. The role in different screens and components should be used instead.
    3. References to --black-color occur 36 times in similar situations. The role in different screens and components should be used instead.
  4. In the end there must be no references to colors, only to roles. Therefore when we add a new app-dark.module.css file for Dark Mode the process will be much easier.
  5. The CSS file can be found here
    1. https://github.com/PalisadoesFoundation/talawa-admin/blob/main/src/style/app.module.css.

Additional context

Image
Image
Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@AQIB-NAWAB
Copy link

Hy @palisadoes, can i work on this issue ?

@palisadoes
Copy link
Contributor Author

Also remove any references that are unused

@palisadoes palisadoes marked this as a duplicate of #3329 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3332 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3333 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3336 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3337 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3338 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3339 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3340 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3341 Jan 28, 2025
@palisadoes palisadoes marked this as a duplicate of #3324 Jan 28, 2025
@rahulch07
Copy link
Contributor

Please coordinate in the #talawa-projects slack channel, and allow others to collaborate in the resulting PR.

I will collaborate with @hustlernik to devise a strategy for working more efficiently. Once finalized, we’ll share it so others can follow as well.

Copy link

github-actions bot commented Feb 8, 2025

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 8, 2025
@palisadoes palisadoes marked this as a duplicate of #3596 Feb 14, 2025
@palisadoes
Copy link
Contributor Author

@hustlernik @rahulch07 Have you been able to work on this? I just had to close a duplicate issue related to this

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 14, 2025
@rahulch07
Copy link
Contributor

@palisadoes
Yes currently working on migrating OrganizationPeople.tsx along with this I will also refactor the CSS of this component.

Steps:

  1. Create a new CSS file app-fixed.module.css(this file will only have css properties that follow proper variable naming)
  2. copy component related css only to this file and use this in css file instead of app.module.css in that component

Likewise this can be followed with all the components and others can also do this on the components they are working.
once CSS is completely refactored this file can be renamed ass app.module.css

would this work?

@palisadoes
Copy link
Contributor Author

Yes. Thanks

@hustlernik
Copy link
Contributor

hustlernik commented Feb 16, 2025

@palisadoes I am working to refactor the CSS for screens whose mongo to postgres migration is completed.

@palisadoes
Copy link
Contributor Author

Thanks.

  1. There are going to be many changes. Don't wait to complete all in one PR.
  2. Please submit successive PRs with small batches of files.
  3. This will help guide others to follow the new paradigm faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request GSoC Priority ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

4 participants