Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kreg bw option #34

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Add kreg bw option #34

merged 3 commits into from
Feb 9, 2025

Conversation

john-p-ryan
Copy link
Contributor

By utilizing the bw argument in the KernelReg function, we can avoid the "spaghetti" problem in the weights by smoothing the mtr estimates. As described by @jdebacker, a bw of 120,000, we can fit the data but avoid the oscillations.

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.37%. Comparing base (10985c1) to head (bd68572).
Report is 41 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (10985c1) and HEAD (bd68572). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (10985c1) HEAD (bd68572)
unittests 3 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   72.81%   49.37%   -23.45%     
===========================================
  Files           3        3               
  Lines         103      160       +57     
===========================================
+ Hits           75       79        +4     
- Misses         28       81       +53     
Flag Coverage Δ
unittests 49.37% <ø> (-23.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdebacker
Copy link
Member

@john-p-ryan Thanks for this PR! LGTM, merging.

@jdebacker jdebacker merged commit 57f417f into PSLmodels:main Feb 9, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants