Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO Centric View #271

Open
karenross opened this issue Apr 12, 2022 · 6 comments
Open

GO Centric View #271

karenross opened this issue Apr 12, 2022 · 6 comments
Assignees
Labels
Web Site Report issue with PRO website (proconsortium.org)

Comments

@karenross
Copy link
Collaborator

The GO-centric view does not show GO Molecular Function terms (Biological Process and Cellular Component terms are OK). For example, see https://proconsortium.org/app/entry/PR:000025934/

@karenross karenross added the Web Site Report issue with PRO website (proconsortium.org) label Apr 12, 2022
@Julie-Cowart
Copy link
Collaborator

Turns out it is literally hard coded

        if r['relation'] == 'has_function':
            data['go']['Molecular Function'][(r['ontology_id'], modifier)].append(r)
        elif r['relation'] == 'participates_in':
            data['go']['Biological Process'][(r['ontology_id'], modifier)].append(r)
        elif r['relation'] == 'located_in':
            data['go']['Cellular Location'][(r['ontology_id'], modifier)].append(r)

Problem is that we seem to be using 'capable_of' now instead of has_function. I can fix by changing the code here.
Are there any other relations we are missing right now that should be included under one of these headings? Here are the relations found in the paf as of the last release.

Relation count
participates_in 1687
capable_of 1554
located_in 1100
has_part 616
associated_with_disease_progression 606
part_of 97
has_agent 27
has_role 10
associated_with_disease_suppression 4
expressed_in 4

@Julie-Cowart
Copy link
Collaborator

Here is how they seem to be used

has_part -> Pfam
associated_with_disease_progression -> Disease Ontology
part_of -> GO complex
has_agent -> Sequence ontology
has_role -> CHEBI:59163 biomarker
associated_with_disease_suppression -> Disease Ontology
expressed_in -> Cell ontology

So the only one that is using GO terms is part_of

@nataled
Copy link
Collaborator

nataled commented Apr 20, 2022

In addition to the relations used in PAF, we also have some used in the OBO. I'll list them here for completeness, then organize them based on function, process, or component considerations in a later comment. Before I do so, however, one question I have is whether or not the annotations shown in the table must come exclusively from the PAF, or does the code allow for these to come from the OBO? If the former, then I might have to move some to the PAF.

RelationCount
only_in_taxon74826
has_canonical_sequence38052
has_gene_template37959
has_part23479
lacks_part6494
has_component1639
output_of809
derives_from57
non-covalently_bound_to41
confers_resistance_to25
capable_of25
part_of19
involved_in3
located_in2
has_quality1

@Julie-Cowart
Copy link
Collaborator

It currently only shows the PAF

@nataled
Copy link
Collaborator

nataled commented Apr 20, 2022

Okay, we can keep it like that and move any relevant annotations that are currently only in OBO to also appear in PAF. I guess the question then becomes: What do we do with annotations that don't use GO (such as the disease-related annotations)? Right now those don't appear at all. Let's discuss that on the PRO call this Friday.

@nataled
Copy link
Collaborator

nataled commented Apr 20, 2022

My first pass categorization. Note:

  1. Some relations are used for definitions in OBO but can be also used for annotation in PAF.
  2. Some complications noted.
  3. Possibility, should we decide to do more with the GO-centric view (unlikely), is to rename the following in the GO-centric view:
  • 'Molecular Function GO Term' to 'Capability Annotations'
  • 'Biological Process GO Term' to 'Process Annotations'
  • 'Cellular Location GO Term' to 'Location Annotations'
  1. Following from 3 above, rename the whole table from 'Functional Annotation' to 'Annotations', rename 'PRO Centric View' to 'Entity-centric View', and rename 'GO Centric view' to 'Annotation-centric View'

Again, to be discussed.

RelationDefFPCOtherNote
participates_in (PAF)xGO: Participation that is not necessarily enabling
involved_in (OBO)xxGO: Participation that is enabling
capable_of (PAF)xGO:
capable_of (OBO)xxGO:
located_in (PAF)xGO:
located_in (OBO)xxGO:
has_part (PAF)xPfam:
has_part (OBO)xvarious
associated_with_disease_progressionxDOID:
associated_with_disease_suppressionxDOID:
part_of (PAF)xGO: (complexes) Technically component, but in PAF it's more a functional annotation
part_of (OBO)xvarious; In OBO these are used for definitions
has_agentxSO: Used to indicate the type of mutation
has_rolexCHEBI:
expressed_inxCL:
only_in_taxonxNCBITaxon:
has_canonical_sequencexUniProtKB:
has_gene_templatexvarious
lacks_partxvarious
has_componentxvarious
output_ofxxGO:
derives_fromxPR:
non-covalently_bound_toxCHEBI:
confers_resistance_toxCHEBI:
has_qualityxSO:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Site Report issue with PRO website (proconsortium.org)
Projects
None yet
Development

No branches or pull requests

3 participants