Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Interactive sequence view' scrolling to always show menu #231

Open
nataled opened this issue Apr 9, 2021 · 4 comments
Open

Fix 'Interactive sequence view' scrolling to always show menu #231

nataled opened this issue Apr 9, 2021 · 4 comments
Assignees
Labels
CanDelay Issues that can be delayed Web Site Report issue with PRO website (proconsortium.org)

Comments

@nataled
Copy link
Collaborator

nataled commented Apr 9, 2021

If a term has many children to view in the alignment view, it becomes necessary to scroll to see all. As one does so, the menu (containing the summary and the link to the zoomed-in view) disappears. This is not desirable. Two possible fixes:

  1. Change the scroll to only affect the sequence representations, leaving the menu area in place.
  2. Allow the user to expand the viewer by drag and drop.

Both are useful, but if only one is implemented, solution (1) is preferred.

Example term: https://proconsortium.org/app/entry/PR%3A000036285/

@nataled nataled added the Web Site Report issue with PRO website (proconsortium.org) label Apr 9, 2021
@nataled
Copy link
Collaborator Author

nataled commented Apr 15, 2021

I also just noticed that the left-right scroll bar located at the bottom of the alignment will also need to stay in view.

@Julie-Cowart
Copy link
Collaborator

better example (that actually loads is Smad2 https://proconsortium.org/app_test/entry/PR:000000364/)

@Julie-Cowart
Copy link
Collaborator

Sticky header is implemented.

Scroll bars at the bottom always being in view is going to be tricky since that's an embedded page (linked to https://proconsortium.org/app_test/visual/msa/view/entry/PR:000000364/) that has contents longer than the viewport so the browser just adds the scroll bars.

@nataled
Copy link
Collaborator Author

nataled commented Jun 4, 2021

Not fully resolved, but can be pushed to production for now. Will look into future improvements (such as always-in-view numbering and bottom scroll bar).

@nataled nataled added CanDelay Issues that can be delayed and removed Discuss labels Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CanDelay Issues that can be delayed Web Site Report issue with PRO website (proconsortium.org)
Projects
None yet
Development

No branches or pull requests

2 participants