ms2/share modal improvements 2 #446

FelipeTrost · 2025-01-20T15:51:17Z

Summary

Share modal embed option now allows selecting a process version to embed.
Enforced in backend: embed only allows process versions
Refactor: use wrapServerCall for generateSharedViewerUrl

… searchparam

…for generateSharedViewerUrl

…vements-2

…abs/proceed into ms2/share-modal-improvements-2

github-actions · 2025-01-31T09:21:44Z

✅ Successfully created Preview Deployment.

https://pr-446---ms-server-staging-c4f6qdpj7q-ew.a.run.app

MaxiLein

Beside minor nit-picks lgtm

MaxiLein · 2025-02-05T10:13:22Z

...dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-embed-in-web.tsx

+          ),
+        onSuccess: (url) => setEmbeddingUrl(url),
+        app,
+      });


Nit-Pick:
Really like the easy way to add some feedback to the user in case of an error with your wrapServerCall, I don't see a reason why one should not use it here as well.

I don't get what you mean, are you saying that I should wrap setEmbeddingUrl in a wrapSeverCall?

MaxiLein · 2025-02-05T10:13:51Z

...dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-embed-in-web.tsx

+          return url;
+        },
+        onSuccess: (url) => setEmbeddingUrl(url),
+        app,


MaxiLein · 2025-02-05T10:14:12Z

...dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-embed-in-web.tsx

+      await wrapServerCall({
+        fn: () =>
+          updateProcessGuestAccessRights(
+            processId,
+            { allowIframeTimestamp: 0 },
+            environment.spaceId,
+          ),
+        onSuccess: () => setEmbeddingUrl(''),
+        app,
+      });


MaxiLein · 2025-02-05T10:16:51Z

...(dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-public-link.tsx

+      wrapServerCall({
+        fn: () =>
+          generateSharedViewerUrl(
+            { processId, timestamp: shareTimestamp },
+            selectedVersionId || undefined,
+          ),
+        onSuccess: (url) => setShareLink(url),
+        app,
+      });
    }


MaxiLein · 2025-02-05T10:17:29Z

...(dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-public-link.tsx

+      await wrapServerCall({
+        fn: async () => {
+          const url = generateSharedViewerUrl(
+            { processId: processId, timestamp },
+            // if there is a specific process version open in the modeler then link to that version (otherwise latest will be shown)
+            selectedVersionId || undefined,
+          );
+          if (isUserErrorResponse(url)) return url;
+
+          const updateRightsResult = await updateProcessGuestAccessRights(
+            processId,
+            {
+              sharedAs: 'public',
+              shareTimestamp: timestamp,
+            },
+            environment.spaceId,
+          );
+          if (isUserErrorResponse(updateRightsResult)) return updateRightsResult;
+
+          return url;
+        },
+        onSuccess: (url) => {
+          setShareLink(url);
+          app.message.success('Process shared');
+        },
+        app,


MaxiLein · 2025-02-05T10:19:17Z

...ment-system-v2/app/(dashboard)/[environmentId]/processes/[processId]/modeler-share-modal.tsx

+    await wrapServerCall({
+      fn: async () => {
+        const url = await generateSharedViewerUrl({
+          processId,
+          timestamp,
+        });
+        if (isUserErrorResponse(url)) return url;

-      link = await generateSharedViewerUrl({ processId, timestamp });
-      await updateProcessGuestAccessRights(
-        processId,
-        {
-          sharedAs: sharedAs,
-          shareTimestamp: timestamp,
-        },
-        environment.spaceId,
-      );
-    } catch (err) {
-      message.error('Failed to generate the sharing url for the process.');
-      return;
-    }
+        const accessUpdateResult = await updateProcessGuestAccessRights(
+          processId,
+          {
+            sharedAs: 'public',
+            allowIframeTimestamp: timestamp,
+          },
+          environment.spaceId,
+        );
+        if (isUserErrorResponse(accessUpdateResult)) return accessUpdateResult;

-    const shareObject = {
-      title: `${processData?.name} | PROCEED`,
-      text: 'Here is a shared process for you',
-      url: `${link}`,
-    };
+        return url;
+      },
+      onSuccess: (url) => (url = url),
+      app,
+    });


MaxiLein · 2025-02-05T10:19:39Z

...nagement-system-v2/app/(dashboard)/[environmentId]/processes/[processId]/modeler-toolbar.tsx

+    return wrapServerCall({
+      fn: () =>
+        generateSharedViewerUrl({ processId, timestamp: 0 }, selectedVersionId || undefined),
+      onSuccess: (url) => window.open(url, `${processId}-${selectedVersionId}-tab`),
+      app,
+    });


MaxiLein · 2025-02-05T10:20:03Z

src/management-system-v2/components/process-export.tsx

+      await wrapServerCall({
+        fn: () =>
+          generateSharedViewerUrl(
+            { processId: definitionId, timestamp: 0 },
+            processVersion || undefined,
+            selectedOptions as string[],
+          ),
+        onSuccess: (url) =>
+          router.push(new URL(url, `${definitionId}-${processVersion}-tab`).toString()),
+      });


MaxiLein · 2025-02-05T10:23:45Z

...dashboard)/[environmentId]/processes/[processId]/modeler-share-modal-option-embed-in-web.tsx

@@ -1,98 +1,109 @@
 'use client';
 import { useEffect, useState } from 'react';
 import { CopyOutlined } from '@ant-design/icons';


Nit-Pick:
Replace with
import { IoMdCopy } from "react-icons/io";
to align with new Buttons

I will do this in the next PR

MaxiLein · 2025-02-05T10:32:40Z

...ment-system-v2/app/(dashboard)/[environmentId]/processes/[processId]/modeler-share-modal.tsx

Nit-Pick:
Replace the export with download to align with the new buttons

I will do this in the next PR

FelipeTrost added 5 commits January 20, 2025 14:07

fix(share-modal): destroy on close -> selected version always matches…

ea10935

… searchparam

feat(ms2/share-modal): select process version for embed

9eed49f

feat(ms2/share): embed only allows process versions + error handling …

588f018

…for generateSharedViewerUrl

fix(ms2/share-modal): check that process version exists

754d093

format

4b027ce

This comment has been minimized.

Sign in to view

FelipeTrost added 2 commits January 21, 2025 15:44

fix(ms2/tests): create version for testing share embed

9313fc2

Merge branch 'main' into ms2/share-modal-improvements-2

67b36d7

This comment has been minimized.

Sign in to view

FelipeTrost added 2 commits January 22, 2025 12:12

Merge remote-tracking branch 'origin/main' into ms2/share-modal-impro…

acbe875

…vements-2

Merge branch 'ms2/share-modal-improvements-2' of github.com:PROCEED-L…

d807852

…abs/proceed into ms2/share-modal-improvements-2

This comment has been minimized.

Sign in to view

Merge branch 'main' into ms2/share-modal-improvements-2

9510eec

anishsapkota had a problem deploying to Research January 27, 2025 18:16 — with GitHub Actions Failure

anishsapkota had a problem deploying to Research January 28, 2025 10:14 — with GitHub Actions Failure

Merge branch 'main' into ms2/share-modal-improvements-2

9e6f82c

OhKai had a problem deploying to Research January 28, 2025 23:20 — with GitHub Actions Failure

OhKai temporarily deployed to Research January 29, 2025 12:32 — with GitHub Actions Inactive

OhKai temporarily deployed to Research January 29, 2025 13:08 — with GitHub Actions Inactive

OhKai temporarily deployed to Research January 29, 2025 13:09 — with GitHub Actions Inactive

This comment has been minimized.

Sign in to view

Merge branch 'main' into ms2/share-modal-improvements-2

6bb6dbe

anishsapkota temporarily deployed to Research January 29, 2025 14:52 — with GitHub Actions Inactive

This comment has been minimized.

Sign in to view

Merge branch 'main' into ms2/share-modal-improvements-2

0ca318e

anishsapkota temporarily deployed to Research January 29, 2025 19:55 — with GitHub Actions Inactive

This comment has been minimized.

Sign in to view

Merge branch 'main' into ms2/share-modal-improvements-2

86e8231

FelipeTrost temporarily deployed to Research January 31, 2025 09:20 — with GitHub Actions Inactive

MaxiLein approved these changes Feb 5, 2025

View reviewed changes

FelipeTrost merged commit da088eb into main Feb 6, 2025
15 checks passed

FelipeTrost deleted the ms2/share-modal-improvements-2 branch February 6, 2025 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ms2/share modal improvements 2 #446

ms2/share modal improvements 2 #446

FelipeTrost commented Jan 20, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 31, 2025

MaxiLein left a comment

MaxiLein Feb 5, 2025

FelipeTrost Feb 6, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

MaxiLein Feb 5, 2025

FelipeTrost Feb 6, 2025

MaxiLein Feb 5, 2025

FelipeTrost Feb 6, 2025

ms2/share modal improvements 2 #446

ms2/share modal improvements 2 #446

Conversation

FelipeTrost commented Jan 20, 2025

Summary

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 31, 2025

MaxiLein left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment